test(ios): stabilize hosted async fixtures - #36
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 914662b59a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| sut.updateGroup(group) | ||
| try await Task.sleep(nanoseconds: 300_000_000) | ||
|
|
||
| for _ in 0..<500 where await mockAccountService.latestSyncedFriends(accountEmail: account.email) == nil { |
There was a problem hiding this comment.
completeAuthenticationAndWait finishes its initial remote load by recording an empty friend-sync snapshot, so latestSyncedFriends(...) is already non-nil before updateGroup schedules the sync under test. This loop can therefore exit immediately and, on an overloaded runner, the assertions can still observe that initial empty snapshot instead of the deduplicated update; poll for a snapshot containing linkedMemberId or for history newer than a captured baseline.
AGENTS.md reference: AGENTS.md:L316-L320
Useful? React with 👍 / 👎.
Summary
Evidence
No product behavior changed in this follow-up; the PayBack fixes are already on main.