Skip to content

[Query]: is this a typo in listReplaceNulls.py ? #4

New issue
New issue
Closed
Closed
[Query]: is this a typo in listReplaceNulls.py ?#4

Description

@adambear82
adambear82
opened on Jul 18, 2018

dynamoPython/workflow/listReplaceNulls.py

Line 18 in 1c8fc5a

results.append(rep) # If the conditional check fails, then append our replacement element to our container list called 'results' in the place of the None at the same index

should be ?

results.append(replacementItem)

as

dynamoPython/workflow/listReplaceNulls.py

Line 10 in 1c8fc5a

replacementItem = 'I\'m not a None' # A replacement item (Note: The backslash is an 'Escape Character' that allows us to use an apostrophe inside of a string)

Activity

  1. Amoursol commented on Jul 18, 2018

    @Amoursol
    Amoursol
    on Jul 18, 2018
    Owner

    Hello Adam,

    This is indeed a typo - thanks for the spot! I've amended it now.

    If you see something similar in future - you can create a 'Pull Request' to amend it :)

  2. Amoursol
    closed this as completedon Jul 18, 2018
  3. Amoursol
    added a commit that references this issue on Jul 25, 2018

    Merge pull request #4 from adambear82/adambear82-helper+1

    b8248d3
  4. Amoursol
    added 2 commits that reference this issue on Sep 20, 2018

    Merge pull request #4 from Amoursol/master

    989a518

    Merge pull request #4 from Amoursol/master

    17ef7f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions