Repository navigation
Report failed MCP config writes - #286
Merged
Eli Pinkerton (wallstop) merged 2 commits intoOct 18, 2026
Merged
Conversation
This was referenced Oct 18, 2026
Automation cannot detect incomplete configuration because the configurator prints write errors and exits zero. Record any failed frontend write and set a nonzero exit status after attempting the other frontends. The blocked-output regression first reproduced the zero exit on main. Ten data-driven paths now prove failed-status forwarding, frontend diagnostics, continued independent writes, directory retention, and read-only dry runs. Successful and unchanged syncs still return zero. Validation: all 42 harness test files, strict pyright, check:fast, check:gate, and npm payload preview pass. Unity 6000.5.2f1 Windows passes 393 EditMode and 15 PlayMode tests. Fixes #285.
Eli Pinkerton (wallstop)
force-pushed
the
fix/mcp-sync-exit-status
branch
from
October 18, 2026 05:59
9e5ffe0 to
cad825e
Compare
Eli Pinkerton (wallstop)
changed the base branch from
main
to
migrate/codex-mcp-writer
October 18, 2026 05:59
Eli Pinkerton (wallstop)
added this pull request to stack #291
October 18, 2026 05:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLOSURE: LLM-GENERATED TEXT
Why: Sync reports success when frontend config writes fail.
What:
Fixes #285.
Note
Medium Risk
Changes devcontainer credential loading and Codex/MCP config write paths; behavior is contract-tested but affects agent startup and sync exit codes.
Overview
MCP sync now fails honestly when a frontend write errors:
configure.mjscatches per-frontend failures, prints labeled ❌ lines, still runs the rest of the plan, and sets exit code 1 if anything failed (fixes #285).Codex persistence moves out of Node into
scripts/mcp_codex_config.py, whichconfigure.mjsinvokes via uv or a Python 3.9+ fallback for managed$CODEX_HOME/config.tomlwrites and workspace.codexpruning..env.localin Bash no longer parses the file inline:load_env_localinenv-local.shrunsenv_local.py(NUL-delimited records), applies exports atomically on success, keeps literal values (no command substitution), and preserves unexported shell variables and existing precedence rules.Harness scope and contract tests cover Codex config, sync exit behavior, and the shell adapter.
Reviewed by Cursor Bugbot for commit cad825e. Bugbot is set up for automated code reviews on this repo. Configure here.