Preserve a few settings to partition export - #1990
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b53014e9d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| manifest.parquet_parallel_encoding = query_context->getSettingsRef()[Setting::output_format_parquet_parallel_encoding]; | ||
| manifest.parquet_compression_method = query_context->getSettingsRef()[Setting::output_format_parquet_compression_method].toString(); | ||
| manifest.output_format_compression_level = query_context->getSettingsRef()[Setting::output_format_compression_level]; | ||
| manifest.parquet_row_group_size = query_context->getSettingsRef()[Setting::output_format_parquet_row_group_size]; |
There was a problem hiding this comment.
When users schedule EXPORT PARTITION with output_format_parquet_row_group_size_bytes (for example to avoid the default 512 MiB cap), this manifest only captures output_format_parquet_row_group_size; the background export context is rebuilt from the manifest, and getFormatSettings consumes both output_format_parquet_row_group_size and output_format_parquet_row_group_size_bytes (src/Formats/FormatFactory.cpp:202-203). Any worker replica will therefore fall back to its default byte limit and produce different row groups than the initiating query. Please persist and restore output_format_parquet_row_group_size_bytes alongside this field.
Useful? React with 👍 / 👎.
arthurpassos
changed the title
|
@codex review, do not care about backwards compatibility |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
arthurpassos
added
antalya
port-antalya
|
What's a point in adding settings in separate PR without using? |
what do you mean by "without using"? You mean why I haven't written tests for it? |
|
My bad, read 'preserve' as 'reserve' |
4 participants
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Route a few more settings through export partition to export part:
output_format_parquet_compression_method,output_format_compression_level,output_format_parquet_row_group_sizeandoutput_format_parquet_row_group_size_bytes.Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: