Skip to content

add ISI and ephys to id_types #780

Open

Description

@dougollerenshaw

the data_access.from_lims.get_id_type function does not find IDs for ISI sessions. We should add ISI sessions and potentially extracellular ephys sessions.

Activity

  1. DowntonCrabby commented on Aug 9, 2021

    @DowntonCrabby
    Collaborator

    I have a branch I'm working on (preconditions_dev) where I refactored the get_id_type function so that it can now get

    ophys_experiment_id
    ophys_session_id
    behavior_session_id
    specimen_id
    donor_id
    cell_roi_id
    cell_specimen_id
    ophys_container_id
    supercontainer_id

    I can very easily add the isi and extracellular ephys sessions to that list as well

  2. dougollerenshaw commented on Aug 10, 2021

    @dougollerenshaw
    ContributorAuthor

    @DowntonCrabby sounds good. What's your timeline for making a PR to get that merged? @seanmcculloch was having an issue with mouseseeks that would be resolved if this issue were resolved, so I figured he could implement this small fix pretty quickly to get himself unstuck.

  3. DowntonCrabby commented on Aug 10, 2021

    @DowntonCrabby
    Collaborator

    My timeline is probably end of week. If @seanmcculloch needs it sooner I can send him the individual functions (there are 3) to implement.

  4. seanmcculloch commented on Aug 10, 2021

    @seanmcculloch
    Collaborator

    That sounds fine @DowntonCrabby Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions