Repository navigation
Extending track references to other detectors - #15997
Open
tubagundem wants to merge 2 commits into
Open
tubagundem wants to merge 2 commits into
tubagundem wants to merge 2 commits into
Conversation
tubagundem
requested review from
afurs,
andreasmolander,
f3sch,
fprino,
jotwinow,
kharlov,
mconcas,
mcoquet642,
noferini,
peressounko,
sahilupadhyaya92 and
shahor02
as code owners
October 22, 2026 13:39
This restores the original formatting of the FT0, FDD and TOF code that the PR does not change functionally. - Only the TrackReference blocks, the new members and their Reset() lines remain.
sawenzel
approved these changes
Oct 23, 2026
sawenzel
left a comment
sawenzel
left a comment
Collaborator
There was a problem hiding this comment.
I tested this PR on top of daily-20261022 with 50 Pythia8 pp events, before and after, with the same seed and SimCutParams.trackSeed=true. The simulation time is unchanged (1:11:06 vs 1:10:52) and o2sim_Kine.root grows by 2%, mainly from the TrackRefs branch (2.34 MB → 2.87 MB compressed). The kinematics are preserved: all 1.09M tracks of the reference are present, and 288 more are stored. I pushed a commit reverting the unrelated formatting changes in FT0, FDD and TOF. Looks good to me.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of https://its.cern.ch/jira/browse/O2-7253