fix(drive-local): report runs the acceptance argv, not just prints DoD (#271) - #375
Merged
Merged
Conversation
#271) Before: `report` only called verifiedPackage() which validates the acceptance contract's integrity (checkScope + validateAcceptance argv-shape checks) then printed the DoD strings verbatim. An unattended tick could exit "REPORT ... DoD: X" even when the DoD was unmet — the argv was never executed. After: `report` runs the same runChecks(pkg) path as `verify` (which was already correct), then re-asserts the package + prints REPORT lines + PACKAGE_VERIFIED. Scope refusal is unchanged (was already enforced via checkScope in verifiedPackage). The DoD is now executable in report, not decorative. Tests: - new: report refuses when the acceptance argv fails against the working tree - new: report prints PACKAGE_VERIFIED only after the argv passes - existing "reporting after SDK suite effects" tests: updated so the in-scope simulation preserves the DoD-required state (writing "broken" back would correctly fail post-#271; existing tests exercised scope enforcement, not DoD, so the fixture data was tightened to isolate the invariant) - existing "allowed untracked change" test: now also fixes value.txt so the DoD is met alongside the untracked file addition 10/10 review tests pass locally. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Session-Id: efeda5df-9b7c-48d4-b2ce-957f5bef0a82
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #271.
reportnow runs runChecks(pkg) (same asverify), so an unattended local drive tick can no longer exitPACKAGE_VERIFIEDwith an unmet DoD. Scope refusal was already enforced viacheckScopeinverifiedPackage; this makes the DoD assertion executable rather than decorative.Test plan
Note
Medium Risk
Changes unattended local-drive gating so
reportcan fail where it previously succeeded; behavior is intentional but affects automation exit codes.Overview
reportnow enforces Definition of Done the same way asverify, not only by validating the acceptance contract and echoing DoD lines.Before printing the diff and DoD,
reportrunsrunChecks(pkg)and re-runsverifiedPackage(), so an unattended local drive tick cannot exit successfully withPACKAGE_VERIFIEDwhile the working tree still fails the pinned acceptance argv. Successful reports also logPACKAGE_VERIFIED: N check(s), matching the verify path.Tests cover refusal when
src/value.txtstays broken, success only after fixes, and updated fixtures so in-scope “suite effect” simulations do not clobber DoD-required state.Reviewed by Cursor Bugbot for commit c970fa8. Bugbot is set up for automated code reviews on this repo. Configure here.