Skip to content

fix(review-swarm): safe terminal diagnostics with legacy fallback (supersedes #283) #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kjgbot merged 1 commit into from
Sep 10, 2026
Merged

fix(review-swarm): safe terminal diagnostics with legacy fallback (supersedes #283) #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion .github/workflows/scripts/swarm-status-diagnostic.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,39 @@
set -euo pipefail

response=${1:-}

# Preferred shape: structured `.failure.{phase,code}`. Each field is
# token-validated so a candidate cannot inject shell/markdown that breaks
# the summary or a workflow command.
failure=$(jq -c '
def token: if type == "string" and test("^[A-Za-z0-9][A-Za-z0-9_.:-]{0,127}$") then . else null end;
(if type == "object" then . else {} end) as $status
| ($status.failure // {}) as $failure
| if ($failure | type) == "object" then $failure else {} end
| {phase: (.phase? // null | token), code: (.code? // null | token)}
| with_entries(select(.value != null))
' <<<"$response" 2>/dev/null)
if [ -n "$failure" ] && [ "$failure" != '{}' ]; then
echo "swarm failure diagnostic: $failure" >&2
echo "- Swarm failure diagnostic: \`$failure\`" >> "$GITHUB_STEP_SUMMARY"
exit 0
fi

# Legacy shape fallback. Every swarm-side taxonomy mode today
# (cursor_expired, workspace_busy, launch queue deadline, sandbox
# provisioning, database_overloaded, etc.) still emits `.result.error`
# rather than `.failure`. Dropping this path would silently lose all
# current diagnostics until the swarm side is migrated. Indent every line
# so a line starting with `::` cannot be parsed as an Actions workflow
# command and three backticks cannot close a fenced block early.
reason=$(jq -r '.result.error // .error // empty' <<<"$response" 2>/dev/null)
if [ -n "$reason" ]; then
safe_reason=$(printf '%s\n' "$reason" | sed 's/^/ /')
echo "swarm failure reason:" >&2
printf '%s\n' "$safe_reason" >&2
{ echo "### Swarm failure reason"; echo; printf '%s\n' "$safe_reason"; } >> "$GITHUB_STEP_SUMMARY"
{
echo "### Swarm failure reason"
echo
printf '%s\n' "$safe_reason"
} >> "$GITHUB_STEP_SUMMARY"
fi
Loading