fix(publish): make the release-tooling fixture hermetic - #209
Merged
Merged
Conversation
The publish pipeline's first real dispatch failed at its own `Test release
tooling` step:
The input did not match /missing package\/dist\/index.js/. Input:
> @relayflows/surface@2.0.0 prepare
> bun run build
$ tsc
error: script "build" exited with code 1
Error: Command failed: npm pack --ignore-scripts --json ...
The fixture copies the real package.json, `prepare` and all. Despite
`--ignore-scripts`, npm ran `prepare` -> `bun run build` -> `tsc` inside a
temp directory that installs no toolchain, so npm failed before pack-release
could emit the assertion the test is actually about.
It passed on my machine only because this host happens to have the toolchain the
fixture never installs — the test was reading the developer's environment, not
the code. Dropping the packaging lifecycle hooks from the fixture makes it
hermetic and tests what it claims to.
Local run passes, but local passed before this change too, so CI is the only
verification that means anything here.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FtQSAcGDta5VH9xiZFT4sR
Session-Id: c228933d-4f94-4d83-9a9a-daf3c83b94f1
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kjgbot
pushed a commit
that referenced
this pull request
Sep 6, 2026
…hen-dispatch is the only path Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FtQSAcGDta5VH9xiZFT4sR Session-Id: c228933d-4f94-4d83-9a9a-daf3c83b94f1
kjgbot
pushed a commit
that referenced
this pull request
Sep 6, 2026
…merged Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FtQSAcGDta5VH9xiZFT4sR Session-Id: c228933d-4f94-4d83-9a9a-daf3c83b94f1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish pipeline's first real dispatch (run 34035686278,
dry_run: true) failed at its ownTest release toolingstep, so nothing downstream ever ran.The fixture copies each real
package.jsonverbatim —prepareincluded. Despite--ignore-scripts, npm ranprepare→bun run build→tscinside amkdtempdirectory that installs no toolchain, so npm failed beforepack-release.mjscould emit themissing package/dist/index.jserror the test asserts on.Dropping
prepare/prepack/postpack/prepublishOnlyfrom the fixture makes it hermetic. It only ever needed the manifests, not the packaging lifecycle.The part worth noting
This test passes on my machine, and passed before this change. It was reading the developer's environment rather than the code — this host has the toolchain the fixture never installs. That is the same shape as the analyzer test that only ever ran here, and it is why I am not claiming a local green as evidence: CI is the only verification that means anything for this one.
Everything else in the pipeline is untested as a result —
Version all packages, the pack-and-assert steps, and the runtime binary build all showskippedin that run because the job died at step 7 of 17.🤖 Generated with Claude Code
https://claude.ai/code/session_01FtQSAcGDta5VH9xiZFT4sR