-
Notifications
You must be signed in to change notification settings - Fork 0
refactor(layout): move sdk/ and surface/ under packages/ #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1cf7bdc
ff50419
1c7f85b
5cdab76
d380008
d920567
235b948
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ | |
| "allowImportingTsExtensions": true, | ||
| "skipLibCheck": true, | ||
| "forceConsistentCasingInFileNames": true, | ||
| "typeRoots": ["../../sdk/node_modules/@types"], | ||
| "typeRoots": ["../../packages/sdk/node_modules/@types"], | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3: The Prompt for AI agents |
||
| "types": ["node"] | ||
| }, | ||
| "include": ["**/*.ts"] | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1: The layout move to packages/ leaves this workflow broken: the steps still set
working-directory: sdkandworking-directory: surface(andnpm ci --prefix sdk), but those directories no longer exist at the repo root after sdk/ and surface/ moved under packages/, so GitHub Actions fails those steps and the whole job aborts before producing the artifact. Update them toworking-directory: packages/sdk,working-directory: packages/surface,npm ci --prefix packages/sdk, and change the preflight guard's../testdata/preflightto../../testdata/preflight.Prompt for AI agents