Repository navigation
fix: conversation search fallback to memories + provenance-free cross-layer dedup - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
search_missesshowed 42 misses/7d, allsource='search_conversations'withhit_count=0— theconversationstable has 0 rows (nothing ingests it), so daily-review flows were flying blind.searchConversations()now falls back to memory recall (markedsource='memories_fallback',note='conversation_search_fallback: memories'); a miss is recorded only when the fallback also returns nothing.migrate-claude-memories.mjs) deduped by summary only forsource='manual'rows, so nativestore_memoryrows were invisible to it → markdown/native duplicate drift. Dedup now matches active memories bycontent_hash/exact content across all sources; summary matching kept only for legacy importer idempotency.Evidence
[{"source":"search_conversations","count":42,"zero_hits":42}],conversations=0Tests
node conversation-fallback-dedup.test.mjs— 5 passed / 0 failed (fallback hit, fallback metadata, no-miss-on-fallback-hit, importer idempotency, provenance-free skip)🤖 Generated with Claude Code