Repository navigation
fix: sandbox agent tools by default - #787
Open
mikemikimike wants to merge 1 commit into
Open
mikemikimike wants to merge 1 commit into
mikemikimike wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agent bash commands could run on the host by default and open Flocks' live SQLite databases. Closing such a connection can remove the database's WAL/SHM sidecars and interrupt database access.
Changes
sandbox.mode: offopt-out after the one-time migration.Tests
git diff --checkpassed.main, while this PR targetsdev; the Windows packaging workflow does not match the changed paths.Compatibility
Existing standard configuration files using the former
offdefault are switched toononce at startup. Users can explicitly setoffafter that migration. If sandbox setup fails, affected agent tool calls return an error instead of running on the host.Fixes #786
#786