Repository navigation
Fix/restore upgrade runtime sync - #54
Merged
Merged
Conversation
added 2 commits
April 5, 2026 20:45
Made-with: Cursor
- Stop passing localhost VITE_API_BASE_URL / VITE_WS_BASE_URL in docker-publish so production images rely on runtime configuration. - Update UpdateModal apply progress in place per stage to avoid duplicate step rows during upgrade. Made-with: Cursor
- Translate root bootstrap install.ps1/install.sh user messages to English - Add PyPI/npm registry variables and URL probe helpers in workspace installers - Align process-cleanup tests with English lock-retry step descriptions - Restore newline at EOF on bootstrap scripts Made-with: Cursor
Provide dedicated install_zh entrypoints and docs so users in China can install from Gitee with default domestic mirrors. Also simplify the default installers to use configured registries directly and cover the new PowerShell encoding rules in CI. Made-with: Cursor
Prefer Gitee and domestic npm/PyPI mirrors for zh locale or explicit cn region upgrades, and align China bootstrap/update archives with the working Gitee refs/tags zip format. Made-with: Cursor
Default zh installers to the China Chrome for Testing mirror so browser setup is faster without changing the existing install flow. Made-with: Cursor
- Retry Windows restart-runtime import check after uv sync (timeout, delays) - Yield UpdateProgress errors instead of raising on restart argv/exec failures - Stream long-running install output via tee (bash) and -StreamOutput (PS1) - Vite: use realpathSync.native root to avoid Windows 8.3 path.relative bugs - Expand updater tests for validation retries and graceful error paths Made-with: Cursor
Set Continue only while streaming external command output so strict modes do not abort the pipeline; restore previous preference in finally. Made-with: Cursor
tempfile.mkdtemp may return short paths under long profile dirs; using them as subprocess cwd breaks Node/Vite path.relative vs long resolved paths. Made-with: Cursor
- Add FLOCKS_NODEJS_MANUAL_DOWNLOAD_URL with en default; zh wrappers set zh-cn page - Bash/PowerShell installers append hint to all Node/npm/npx-related failures - Extend install script source tests for new env var and helpers Made-with: Cursor
Align the process cleanup test with the current installer behavior by removing assertions for source probing helpers that no longer exist. Made-with: Cursor
duguwanglong
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores reliable upgrade / restart-runtime behavior on Windows, hardens the installer and updater UX around Node/npm failures and strict PowerShell modes, improves China-region install and upgrade paths (mirrors and dedicated bootstrap entrypoints), and fixes Docker WebUI env handling plus UpdateModal progress reporting.
Motivation
path.relativedisagreed with resolved long paths.ErrorActionPreference, and optional China mirrors for faster, more reliable bootstrap and upgrades.Changes
Updater & runtime (Windows)
cwd(avoids Node/Vitepath.relativemismatches vs long resolved paths).uv sync(timeouts/delays), surfaceUpdateProgresserrors instead of hard-failing on restart argv/exec issues.tee, PowerShell-StreamOutput).realpathSync.nativefor project root to avoid Windows short-path issues.Installers (bash / PowerShell)
ErrorActionPreferenceduringStreamOutputnative runs (temporarilyContinue, restore infinally).FLOCKS_NODEJS_MANUAL_DOWNLOAD_URL(EN default; zh wrappers point at zh-cn page); appended on Node/npm/npx-related failures; tests updated.install_zhentrypoints and docs (Gitee + domestic mirrors by default); default installers use configured registries with probe helpers.install.ps1/install.sh, registry URL variables, aligned process-cleanup test strings.Updater (China / zh)