Repository navigation
Advnet multi tunnel - #310
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reopen pr#308
Description
Mirrors the BGP dynamic routing additions across both published specs (
static/api.yamlandstatic/models.yaml) for the VPN network infrastructure schemas:bgpAsn,bgpPeeringAddress,adobeApipaAddressadobeAsn; documented multi-connection support (recommended max 20) and static/BGP mix in theconnectionsdescriptionaddressSpaceis no longer required (it's optional when a connection uses BGP dynamic routing; required only for static-routing connections)Related Issue
N/A — documentation update tracking the network-infrastructure BGP feature.
Motivation and Context
The self-service-gateway now supports BGP dynamic routing for VPN network infrastructures. The public API reference did not describe the new fields (
bgpAsn,bgpPeeringAddress,adobeApipaAddress,adobeAsn) or the relaxedaddressSpacerequirement, so integrators had no documented way to configure dynamic routing. This change brings the two published specs in line with the implementation. Field descriptions and constraints were verified against the cm-hubself-service-gatewaysource of truth (VpnInfrastructureRepresentation,NetworkInfrastructureService).How Has This Been Tested?
static/api.yamlandstatic/models.yamlparse cleanly as YAML.169.254.21.0–169.254.22.255,adobeAsnrange64512–65514/65521–65534, bgpAsn↔bgpPeeringAddress co-presence,MAX_VPN_CONNECTIONS = 20, conditionaladdressSpacerequirement).Types of changes
Checklist: