Skip to content

Coefficients by Segment Necessary for Preprocessor #333

Description

@danielsclint

Should the coefficients line 96 be added to the local dictionary before the expressions are evaluated for the preprocessor_settings? In the ARC implementation, tour_mode_choice_annotate_choosers_preprocessor.csv, references coefficients defined in the tour_mode_choice_coeffs and tour_mode_choice_coeffs_templates. They would only be available if the coefficients were added to the local_dict before the expressions are evaluated in line 88.

if preprocessor_settings:
simulate.set_skim_wrapper_targets(choosers, skims)
expressions.assign_columns(
df=choosers,
model_settings=preprocessor_settings,
locals_dict=locals_dict,
trace_label=trace_label)
# - compute logsums
coefficients = simulate.get_segment_coefficients(logsum_settings, tour_purpose)
logsum_spec = simulate.read_model_spec(file_name=logsum_settings['SPEC'])
logsum_spec = simulate.eval_coefficients(logsum_spec, coefficients, estimator=None)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions