Skip to content

park_and_ride_lot_choice fails with sharrow #1111

Description

@bricegnichols

Describe the bug
The park and ride lot choice model crashes when loading skims because there is no attribute skim_dict.skim_info.omx_keys.keys(). This crash only happens when running with sharrow.

To Reproduce
Steps to reproduce the behavior:
Input configs and data available here: https://psrc.files.com/files/2013/Outgoing/activitysim_inputs

  • Copy inputs to local machine
  • Clone main Activitysim branch (as of 9/8/26)
  • Activate uv environment and run with three configs settings for sharrow, multiprocessing, and standard configs:

python activitysim\cli\run.py -c configs_sh -c configs_mp -c configs -d sc_09_04_26_asim_main_test_2023_data -o output

To test without sharrow, remove "-c configs_sh" from above and re-run. Start model from the step before park and ride lot choice.

Expected behavior
This section is checking that a skim name exists in the skims file before continuing on. It should look for the skim name in a standard format, but the attribute "skim_info" is only available when sharrow is not being run. The best I can tell is that if sharrow is enabled in los.load_data(), the method get_skim_dict() is called instead of create_skim_dict(). The former never defines skim_info, while the latter defines it here.

Additional info
I also tested commenting out this section and running with sharrow, which did work.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't working/bug f

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions