Fix example smoke tests in upstream and Windows environments - #20
Merged
jpn-- merged 1 commit intoSep 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Standard 1-Zone Example job in ActivitySim's CI fails because the example's smoke tests assume they are running in its own locked environment. They require the installed development version of ActivitySim to equal the pinned release, and attempt to execute Python shebang scripts directly on Windows (
WinError 193). The model/configuration tests passed in the reported failing job.This change scopes launcher and lockfile checks to the example's explicitly selected
ACTIVITYSIM_TEST_SOURCE=lockedormainenvironment. External ActivitySim environments still run the model regression and script configuration tests. Windows launcher checks use the documenteduv run --lockedcommand; POSIX checks continue to exercise direct execution.The existing CI workflow now includes Windows smoke coverage and checks the external-environment behavior. The README documents how to select each testing mode. No new workflow files are added.
Validation: all four CI jobs passed: full Linux regression suites and Windows smoke tests, each against the locked release and ActivitySim main. Local smoke tests also passed in the locked example environment and a separate ActivitySim development environment.