Skip to content

Fix subsurface_color range to indicate 3-dimensionality - #278

Open
MAP233224 wants to merge 2 commits into
AcademySoftwareFoundation:dev_1.1.1from
MAP233224:patch-1
Open

MAP233224 wants to merge 2 commits into
AcademySoftwareFoundation:dev_1.1.1from
MAP233224:patch-1

Conversation

@MAP233224

Copy link
Copy Markdown

No description provided.

jstone-lucasfilm and others added 2 commits June 28, 2024 14:05
This changelist merges v1.1 development from dev_1.1 to main, in preparation for marking the release of OpenPBR v1.1.
Signed-off-by: MAP <74914349+MAP233224@users.noreply.github.com>
@linux-foundation-easycla

Copy link
Copy Markdown

CLA Not Signed

@AdrienHerubel
AdrienHerubel changed the base branch from main to dev_1.1.1 September 30, 2025 15:19
@AdrienHerubel
AdrienHerubel self-requested a review September 30, 2025 15:19

@AdrienHerubel AdrienHerubel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, though it should target the 1.1.1 branch and needs CLA signed from contributor.

@MAP233224

Copy link
Copy Markdown
Author

The change looks good, though it should target the 1.1.1 branch and needs CLA signed from contributor.

I really don't know what that is and can't be bothered to sign it, if you want you can delete this PR and ask someone who's already signed it to make the change properly, it's really minor.

@najibna najibna left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parametrization.md.html now has $[0, 1]^3$ for subsurface_color, which matches color3, but index.html still lists $[0, 1]$ — those tables should stay in lockstep.

The PR also bumps spec/nodedef to v1.1, retargets thin_film_ior, switches subsurface_radius_scale to color3, and retunes example defaults. I'd split the type/range fix from that version-bump churn; this likely belongs on the 1.1.1 line once CLA is signed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants