Conversation
现象：关闭「理智作战」后，脚本管理页的 MAA 用户卡片仍显示主关卡与备选关卡标签； 开启「活动关优先」也没有任何标签体现。 修法：MaaUserConfig.getTags() 只在 Task.IfFight 开启时追加主关卡 / 备选标签； Task.IfActivityFirst 开启时追加「活动关优先」标签（排在关卡标签前，与执行顺序一致）。 不改配置格式与 schema。 Refs AUTO-MAS-Project#558 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
审查者指南本 PR 调整 MaaUserConfig.getTags() 的标签生成逻辑：活动关优先标签独立随 IfActivityFirst 显示，主关卡和备选关卡标签仅在 IfFight 开启时生成，同时保持原有理智作战标签内容与样式不变；具体活动关卡名称解析仍未纳入本次改动。 MAA 用户标签生成流程图flowchart TD
A[getTags] --> B{IfActivityFirst enabled?}
B -- Yes --> C[Add 活动关优先 cyan tag]
B -- No --> D{IfFight enabled?}
C --> D
D -- Yes --> E[Resolve stage information]
E --> F[Add 主关卡 tag]
F --> G{Backup stages available?}
G -- Yes --> H[Add 备选 tag]
G -- No --> I[Add notes tag]
D -- No --> I
H --> I
文件级变更
可能关联的议题
提示与命令与 Sourcery 交互
自定义使用体验访问你的控制面板，即可：
获取帮助Original review guide in EnglishReviewer's Guide本 PR 调整 MaaUserConfig.getTags() 的标签生成逻辑：活动关优先标签独立随 IfActivityFirst 显示，主关卡和备选关卡标签仅在 IfFight 开启时生成，同时保持原有理智作战标签内容与样式不变；具体活动关卡名称解析仍未纳入本次改动。 Flow diagram for MAA user tag generationflowchart TD
A[getTags] --> B{IfActivityFirst enabled?}
B -- Yes --> C[Add 活动关优先 cyan tag]
B -- No --> D{IfFight enabled?}
C --> D
D -- Yes --> E[Resolve stage information]
E --> F[Add 主关卡 tag]
F --> G{Backup stages available?}
G -- Yes --> H[Add 备选 tag]
G -- No --> I[Add notes tag]
D -- No --> I
H --> I
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
你好——我发现了 1 个问题
面向 AI 代理的提示
请处理本次代码审查中的评论：
## 单独评论
### 评论 1
<location path="app/models/config.py" line_range="1163" />
<code_context>
- if isinstance(plan, MaaPlanConfig):
+ # 活动关优先标签：独立任务，只看自身开关，不受理智作战开关影响
+ if self.get("Task", "IfActivityFirst"):
+ tags.append({"text": "活动关优先", "color": "cyan"})
+
+ # 关卡信息标签：只在理智作战开启时显示
</code_context>
<issue_to_address>
**问题（bug_risk）：** 新增的“活动关优先”标签使用了颜色 `cyan`，但 `TagItem.color` 模式仅允许使用 red、blue、green、yellow、orange、purple、pink、brown、black、white、gray、silver 和 gold。根据文档中的 `TagItem` 契约验证 JSON 的消费者会拒绝此标签。
**触发条件：** 启用 `Task.IfActivityFirst`，且对生成的标签列表进行模式验证时。
**建议修复：** 将 `cyan` 添加到 `TagItem.color` 允许的字面量中，或使用现有允许的颜色之一。
```suggestion
tags.append({"text": "活动关优先", "color": "blue"})
```
</issue_to_address>Sourcery 评估
等待批准。 请先处理 1 个发现的问题。
阻塞性发现：app/models/config.py:1163
Original comment in English
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="app/models/config.py" line_range="1163" />
<code_context>
- if isinstance(plan, MaaPlanConfig):
+ # 活动关优先标签：独立任务，只看自身开关，不受理智作战开关影响
+ if self.get("Task", "IfActivityFirst"):
+ tags.append({"text": "活动关优先", "color": "cyan"})
+
+ # 关卡信息标签：只在理智作战开启时显示
</code_context>
<issue_to_address>
**issue (bug_risk):** The new "活动关优先" tag uses color `cyan`, but the `TagItem.color` schema only permits red, blue, green, yellow, orange, purple, pink, brown, black, white, gray, silver, and gold. Consumers validating the JSON against the documented `TagItem` contract reject this tag.
**Triggers:** When `Task.IfActivityFirst` is enabled and the generated tag list is schema-validated.
**Suggested fix:** Add `cyan` to `TagItem.color`'s allowed literals, or use one of the existing permitted colors.
```suggestion
tags.append({"text": "活动关优先", "color": "blue"})
```
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: app/models/config.py:1163
cyan 不在 TagItem.color 的取值范围内，改用前后端都支持、MAA 标签尚未使用的 gold。 Refs AUTO-MAS-Project#558 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
批量审查意见（AI 辅助）· PR #982
实现核对
一个既有隐患（非本 PR 引入，但这次重排让位置更显眼，建议顺手兜一下）
UI/UX
不确定项
（本条为 AI 辅助的批量审查输出，已逐项核对到文件行与命令输出；如与维护者判断不一致，以维护者为准。） |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #558（只做了标签跟随开关；issue 里「显示具体活动关卡」未做）
Task.IfFight）开启时显示；开启活动关优先（Task.IfActivityFirst）时加一个「活动关优先」标签。MaaUserConfig.getTags()；理智作战开启时原有标签的文字、颜色、顺序不变（git diff -w只有新增的判断与标签）。具体活动关名要走异步的关卡信息解析，不适合放进同步的getTags()，留作后续。本地验证
tests/models42 passed。python -m pytest tests --collect-only -q退出码 0；ruff 通过。🤖 Generated with Claude Code
Sourcery 摘要
使脚本管理页中的 MAA 用户标签根据理智作战和活动关优先开关准确显示。
Bug 修复：
杂项：
Original summary in English
Sourcery 摘要
使 MAA 脚本管理用户标签与理智作战和活动优先级设置保持一致。
Bug 修复：
杂项：
Original summary in English
Summary by Sourcery
Align MAA script-management user tags with the sanity-combat and activity-priority settings.
Bug Fixes:
Chores: