shallow copy of parameters

[moteus]

Now execute method do deep copy so it's not possible pass any
object represented as table.
Another way is just have another method which pass all args as is to handler.

[moteus]

I use resolve directly so i can pass any to cb.
Bur istill not sure why need deep copy

[mikz]

@moteus would be nice to point to some code in question.

[moteus]

local t = {}
-- now router do not pass `t` but make new copy of it
r:match('GET', '/', function(params) assert(params.a == t) end
r:execute('GET', '/', { a = t }) -- why need copy `t` but not just send same value?

[mikz]

So the code in question is

router.lua/router.lua

Lines 80 to 113 in d40c94f

	local function merge(destination, origin, visited)
	if type(origin) ~= 'table' then return origin end
	if visited[origin] then return visited[origin] end
	if destination == nil then destination = {} end
	for k,v in pairs(origin) do
	k = merge(nil, k, visited) -- makes a copy of k
	if destination[k] == nil then
	destination[k] = merge(nil, v, visited)
	end
	end
	return destination
	end
	local function merge_params(...)
	local params_list = {...}
	local result, visited = {}, {}
	for i=1, #params_list do
	merge(result, params_list[i], visited)
	end
	return result
	end
	------------------------------ INSTANCE METHODS ------------------------------------
	local Router = {}
	function Router:resolve(method, path, ...)
	local node = self._tree[method]
	if not node then return nil, ("Unknown method: %s"):format(tostring(method)) end
	return resolve(path, node, merge_params(...))
	end

And I'd say it is there because you can pass several params to execute like: r:execute('GET', '/', { a = t }, { b = t2 }, {c = t3}).
I'm not sure if that can be fixed or how.

[moteus]

I understand but when you merge you do not need merge value
In your example it is more predictable result is { a = t, b = t2, c = t3}
But now router also makes copy of t, t2 and t3 so result is
{ a = merge(nil, t), b = merge(nil, t2), c = merge(nil, t3) }
I do not is this by design or not.
In fact it also makes copy of keys as whell