Repository navigation
Clean up Model Conversion Script #131
Description
Currently the model conversion script will create a bucket export MODEL_BUCKET=gs://${USER}-maxtext. However, it may be the case that the gs://${USER}-maxtext path already exists, which I imagine would break the script.
Solution: Be able to read in a few more arguments MODEL_BUCKET and BASE_OUTPUT_DIRECTORY. We should also delete references to DATASET_PATH.
Metadata
Metadata
Assignees
Labels
No labels
Activity
JoeZijunZhou commentedon Aug 16, 2024
If the bucket exists, the script will continue and use the existing ones IIRC. But feel free to refactor it to improve UX.
yeandy commentedon Aug 19, 2024
Yes, but only if the current
USERis the original creator/owner of bucket, right? A different user could have the same value forUSER, which I think would break the workflow.