Repository navigation
fix thrown shield stance swapping - #4277
Merged
Merged
Conversation
LtRipley36706
approved these changes
Mar 9, 2025
WarlockHolmez
added a commit
to daralet-ac/ACE
that referenced
this pull request
Oct 7, 2026
…nce fixes from upstream ACE (#1285) * Let Life Magic projectile spells that deal physical damage fire Life school projectiles that aren't drains (Hunter's Lash 2970, Thorn Valley 6159) have a physical DamageType, so they hit the "Unknown DamageType for LifeProjectile" warning and were never launched. Hunter's Lash is on the player allowed spell list. Upstream ACEmulator#4228 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LDKfgWjXHL7EKz8foWrd5e * Stay in missile combat when a shield is equipped or removed with a thrown weapon Equipping or removing a shield while holding a thrown weapon switched the player to melee combat. Upstream ACEmulator#4277 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LDKfgWjXHL7EKz8foWrd5e * Cache WeenieObject type checks for the physics engine IsCreature/IsPlayer/IsCorpse/IsStorage resolved the WorldObject weak reference and did a type check on every call, and they are called constantly from collision and motion code. They are now computed once at construction. WeenieObject is immutable, so PhysicsObjs without a weenie share one DummyObject instead of allocating their own. Method signatures are unchanged for mods. Upstream ACEmulator#4212 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LDKfgWjXHL7EKz8foWrd5e --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to kewne for reporting this issue
repro steps:
expected:
actual:
similar problems with unequipping shield while in thrown shield combat stance, and swapping between sword+shield and thrown+shield while in combat stance also fixed