Consolidate brownfield packet #4: portal working-reps 1RM

[9thLevelSoftware]

Summary

• Consolidates brownfield scan 8951e31b packet Plan custom exercises and gamification features #4 onto current main (4929c1e2f9cc98cfb6dcb08475cff3aebfe059b5).
• This is consolidation of an unreviewed remote remediation branch; no other brownfield packets are included.
• Original commits:
  • fc049dc522e1eb538b74f16841fe2ca78fd53eba — fix(sync): estimate portal 1RM from workingReps, demote store-verbatim
  • 1ed8fd86df53f3f7a543d938e81ff248befd0efe — test(sync): pin portal 1RM fixtures to workingReps, not fallback

Behavior

• Portal exercise payloads calculate the canonical per-cable hybrid 1RM from workingReps when positive, falling back to totalReps only when workingReps is zero.
• Zero-weight/zero-rep estimates remain absent, without dropping a separate velocity estimate.
• DTO guidance no longer asserts unverified portal store-verbatim/recompute behavior.
• Portal sync fixtures explicitly cover warmup exclusion, the legacy fallback, zero-rep absence, and hybrid/VBT field separation.

Verification

• ./gradlew -Pskip.supabase.check=true :shared:testAndroidHostTest --tests 'com.devil.phoenixproject.data.sync.PortalSyncAdapterTest' — PASS (75 tests, 0 failures).
• ./gradlew -Pskip.supabase.check=true :shared:testAndroidHostTest — PASS (3,729 tests, 0 failures).
• ./gradlew -Pskip.supabase.check=true :shared:compileKotlinIosArm64 :shared:compileTestKotlinIosArm64 — PASS.
• Packet patch comparison against the original range is byte-for-byte equivalent; final diff is limited to the four packet files.

Refs brownfield scan 8951e31b packet #4

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-08-30T23:47:51.314073Z	f95db67	PR opened
🔒 Security Review	✅ Completed 2026-08-30T23:49:30.582697Z	f95db67	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[kilo-code-bot]

Code Review Roast 🔥

Verdict: No Issues Found | Recommendation: Merge

Oh wait, this PR is actually clean. I need to sit down. I had my flamethrower warmed up and everything.

A bug fix that fixes the bug, tests that pin every branch of the new logic (warmup exclusion, working==0 fallback, both-zero null, hybrid-null-doesn't-drop-velocity), and doc updates that demote "portal stores verbatim" to "portal store-verbatim is unverified" instead of asserting unverified behavior. Honestly? This is the kind of consolidation packet that makes a senior engineer do a slow clap at 2am.

The only quibble — and it's a nitpick, not a finding — is that the test factory's workingReps = workingReps ?: totalReps silently turns "I forgot to pass workingReps" into "workingReps == totalReps." The author flagged this in the commit message and pinned the zero-fallback explicitly, so it's fine. Future contributors just need to remember to pass workingReps=0 when they mean it.

📊 Overall: Like finding a unicorn in production — a bug fix that doesn't sneak in three new abstractions, a doc rewrite that strips confidence instead of adding it, and tests that test behavior instead of mocks. Suspiciously competent. 10/10, would review again.

Files Reviewed (4 files)

• CLAUDE.md - 0 issues
• shared/src/commonMain/kotlin/com/devil/phoenixproject/data/sync/PortalSyncAdapter.kt - 0 issues
• shared/src/commonMain/kotlin/com/devil/phoenixproject/data/sync/PortalSyncDtos.kt - 0 issues
• shared/src/commonTest/kotlin/com/devil/phoenixproject/data/sync/PortalSyncAdapterTest.kt - 0 issues

---

_{Reviewed by minimax-m3 · Input: 41.4K · Output: 7.1K · Cached: 232.6K}

_{Review guidance: REVIEW.md from base branch main}