feat: replace Vitruvian-style mark with Phoenix cable logo - #708
Conversation
Swap splash, Android launcher, iOS App Store icon, and docs assets to the new phoenix-and-cables mark. Keep the inner hex plate intact and flatten a black plate only for the iOS 1024 icon.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Use a transparent source for generated launch icons
When iosApp/setup_launch_assets.sh is run, lines 14 and 29–35 resize this file directly into every LaunchIcon image. This commit changes the source from RGBA artwork to an RGB image flattened onto black, so the generated launch logo appears as a black square against the configured light launch background instead of blending into it. Keep this flattened file for the App Store icon, but have the launch-asset script use the transparent logo source.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Code Review Roast 🔥Verdict: No Issues Found | Recommendation: Merge Oh wait, this incremental actually fixes my previous P3 nit. I had my flamethrower warmed up to complain about 📊 Overall: Like finding out the junior dev actually read the previous review notes — rare, refreshing, and slightly suspicious. The original P3 (Italian file-shape drift) is closed. The Codex P2 launch-icon flattening concern remains an optional follow-up, not a blocker for this branding PR. Files Reviewed (1 file in incremental diff)
Previous Review Summary (commit 0ade737)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 0ade737)Verdict🟡 Approve with fixes — branding swap is visually sound and the textual churn is small. One structural inconsistency in Correctness/Safety Findings1. 📏 P3 —
2. ℹ️ Acknowledged — Codex P2 (launch-icon flattening)
3. ✓ Verified consistent (no issue)
Ponytail Review🐴 Ponytail: Already lean. One ponytail, no frills, no braids — 7 lines of text across 13 files, the rest are PNG swaps that don't need a haircut. Just slide the Italian string into its proper spot and ship. Suggested Minimal PatchIn
In
Final Merge Guidance✅ Safe to merge once the Italian strings placement is normalized. Branding is consistent end-to-end across Android adaptive icon, iOS App Store icon, in-app splash/logo, docs favicon, and the 🩹 Fix: https://app.kilo.ai/cloud-agent-fork/review/5a66f7c3-4f4c-4ca8-9543-844916c5c365 Reviewed by minimax-m3 · Input: 25.5K · Output: 1.8K · Cached: 142.5K Review guidance: REVIEW.md from base branch |
values-it is a partial overlay, not a full locale file. Move the new key off the app_name header and next to the existing cd_* sibling so translators keep accessibility copy together.
* fix: remove remaining Vitruvian IP outliers after catalogue swap E2E audit follow-up to #706/#708 for the Vitruvian takedown request. HEAD was already clean of the exercise dataset, the mux/jwplayer streaming stack and the decompilation docs; this removes what survived: - Drop stale "572 exercises with video" copy (TESTFLIGHT_NOTES, docs/index.html), add non-affiliation line to TestFlight notes. - Delete final-visuals/ QA screenshots that render the old catalogue (three show a live stream.mux.com playback URL). Unreferenced by code. - Migration 39: replace the six legacy catalogue IDs (+ catalogue-name comments) with the equivalent name-based heal on non-custom rows; drop the redundant RoutineExercise ID block. Idempotent, data-only; Kotlin mirror and SchemaParityTest updated to synthetic IDs. - Reword ~70 comments/identifiers that cited the official app or decompiled internals as the source of behaviour (BLE/protocol, diagnostics, UI, tests, third-party Kable patch, almanac). createOfficialStopPacket() -> createSoftStopPacket(); DiagnosticFaultCategory.VITRUVIAN("Vee") -> CONTROLLER("Controller"); fault labels re-authored in Phoenix wording. - Delete HardwareValidationTest scaffold (described the official app's Sample struct); update BlePacketCapture comments. - Remove dead media3/HLS version-catalog aliases and unused video strings; "video" wording -> demo images in en/de/es/fr/nl. - Neutralise safe branding strings (backup filenames, export headers, install guides, bug template, disconnect prompt); persisted names (vitruvian.db, vitruvian_preferences, video_playback key) untouched. - LegacyCatalogueIdMap KDoc now states keys are migration-only opaque IDs. Verified: :shared:testAndroidHostTest + :androidApp:testDebugUnitTest + verifyCommonMainVitruvianDatabaseMigration -> 3,724 tests, 0 failures. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RpYk6iyjaMzC4DjiMEBwvK * Bump app version to 1.0.0 --------- Co-authored-by: Codex <codex@openai.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Replace the Vitruvian-style app mark
The previous splash and launcher artwork was a play on the Vitruvian “V” logo. This swaps it for the new phoenix-and-cables mark.
What changed
The inner hex, cables, and handle are kept. This is branding only — no workout behavior changes.