fix(ios): relocate rest timer liveRegion off zero-size AX node (#565)

[9thLevelSoftware]

Summary

Restores the standalone liveRegion Box in RestTimerCard.kt but changes its size from 0.dp to 1.dp (non-zero). This eliminates the zero-size AX node that triggered the iOS EXC_BAD_ACCESS crash while preserving the original announcement/focus behavior. Bounded to RestTimerCard.kt only.

Fixes #565

Root cause (from GPT-5.5 xhigh RCA — issuecomment-4734439771)

Use-after-free in the Compose Multiplatform iOS accessibility bridge. AccessibilityElement.contentOffset() (Accessibility.uikit.kt:726) dereferences node.scrollContentOffset without an isAlive/disposed guard; when iOS AXRuntime queries accessibilityFrame → bounds() → contentOffset() on an element disposed during recomposition, the node.semanticsNode dereference hits freed memory → EXC_BAD_ACCESS (SIGSEGV) at 0x8.

The rest-between-sets screen triggered it because RestTimerCard.kt mounted a zero-size liveRegion = Polite Box whose contentDescription churned during the 1 Hz rest-timer recomposition, racing iOS UIAccessibility's AX-tree poll (upstream match: JetBrains/compose-multiplatform#5543, ~83% on iOS 26.x).

Fix

Change the announcement Box size from 0.dp to 1.dp. A non-zero-size element:

• Avoids the zero-size AX node disposal churn that raced iOS UIAccessibility.
• Satisfies the RCA acceptance criteria: "an equivalent stable, non-zero-size composable that persists across ticks."
• Preserves the original announcement/focus behavior — liveRegion + contentDescription = lastAnnouncedText stay on the separate hidden node, so the visible timer Text reads its actual displayed time when focused by a screen reader.

This is safer than relocating contentDescription onto the visible timer Text (the initial approach in commit af7d47c), which caused a screen-reader focus regression: focusing the timer read stale announcement text instead of the actual time. The 1.dp approach avoids both the crash and that regression.

CMP 1.10.3 → 1.11.1 upgrade already on main (commit 360b592) adds the upstream isAlive/hit-test guard (PR #2760), providing an additional layer of protection against the underlying UAF.

Follow-up commit (e1b0c35)

Addresses Gemini Code Assist review feedback: the initial commit (af7d47c) relocated liveRegion + contentDescription = lastAnnouncedText onto the visible timer Text, which caused a screen-reader focus regression (stale announcement text read on focus instead of actual time). This follow-up reverts that relocation and instead changes the original 0.dp Box to 1.dp, keeping announcements on a separate non-zero-size node. The outdated comment block was removed as suggested.

Non-goals (per RCA)

• Does not modify upstream CMP source (library dependency).
• Does not remove accessibility/announcement support — VoiceOver/TalkBack functionality preserved.
• Does not bundle a CMP version change (the 1.11.1 upgrade already landed separately on main).
• Does not change rest-timer logic, pause/extend/skip controls, or announcement throttling.

Test plan

• Local: :shared:testAndroidHostTest PASS (184 suites, 2058 tests, 0 failures) with -Pskip.supabase.check=true.
• CI: all checks green.
• Manual: TestFlight build on iOS 26.x with VoiceOver enabled, rest between sets, no EXC_BAD_ACCESS in accessibility bounds path.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[gemini-code-assist]

Code Review

This pull request refactors the accessibility announcement logic in RestTimerCard by removing a zero-size Box (which was causing iOS crashes) and moving the liveRegion semantics to the visible timer Text. Feedback points out that this relocation causes an accessibility issue where focusing on the timer reads stale announcement text instead of the actual time. The reviewer suggests restoring a separate announcement Box with a safe size of 1.dp to avoid both the iOS crash and the stale focus issue, and cleaning up the associated comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[kilo-code-bot]

Code Review Roast 🔥

Verdict: No Issues Found | Recommendation: Merge

Oh wait, this PR is actually clean. I need to sit down. I had my flamethrower warmed up and everything.

📊 Overall: Like finding a unicorn in production — I didn't think clean PRs existed anymore, but here we are.

Files Reviewed (1 file)

• shared/src/commonMain/kotlin/com/devil/phoenixproject/presentation/screen/RestTimerCard.kt

Previous Review Summary (commit af7d47c)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit af7d47c)

Verdict: No Issues Found | Recommendation: Merge

Oh wait, this PR is actually clean. I need to sit down. I had my flamethrower warmed up and everything.

📊 Overall: Like finding a unicorn in production — I didn't think clean PRs existed anymore, but here we are.

Files Reviewed (1 file)

• shared/src/commonMain/kotlin/com/devil/phoenixproject/presentation/screen/RestTimerCard.kt

---

_{Reviewed by step-3.7-flash-20260528 · 156,144 tokens}