[Bug]: Serious graphics/UI bug plus issues with users

[mu71rd]

Platform

iOS

OS Version

26.3.1

App Version

0.7.0

Device Model

iphone 17 pro

Bug Description

I have a persistent and show-stopping bug on my version of the app. This shows as a graphics bug which craps out the interface entirely and I'm left with a rapidly scrolling screen and the only recovery is to kill the app. This happens nearly every time I do a set - sometimes I'll get one set out before it crashes.

It's entirely reproducible.

I do wonder if it started when I added a second user. I don't remember it doing this before then. This might also co-incide with the fact that I cannot now delete my second user. If I try to, the app just dies straight away. I am stuck with two users now so I can't now test it again with just one.

Don't seem to be able to upload a video of it, but I have one if you want it.

Steps to Reproduce

Set up a single workout and perform it. Graphics usually go wrong after the first set summary screen.

Expected Behavior

No response

Logs/Screenshots

Checklist

• I have searched existing issues to ensure this is not a duplicate
• I have tested with the latest version of the app

[9thLevelSoftware]

Root Cause Identified & Fixed

PR: #396

Primary Bug: UI Corruption (overlapping RoutineComplete screens)

Root cause: Navigation race condition between two StateFlow updates during routine completion.

When the last set finished, showRoutineComplete() set routineFlowState = Complete while workoutState was still SetSummary. In the recomposition window between those two state updates:

1. ActiveWorkoutScreen saw RoutineFlowState.Complete → navigated to RoutineComplete (no guard preventing this during active workout states)
2. EnhancedMainScreen saw workoutState = SetSummary → shouldResumeActiveWorkout() returned true → force-navigated back to ActiveWorkout
3. New ActiveWorkoutScreen instance (fresh hasNavigatedAway = false) saw Complete again → navigated to RoutineComplete again
4. Result: multiple overlapping RoutineComplete screens stacking on the nav backstack

Your screenshot confirmed this — doubled trophy icons and overlapping "ROUTINE COMPLETE" text.

Fix (3 layers of defense):

• Set workoutState = Idle before showRoutineComplete() so shouldResumeActiveWorkout() returns false before the Complete navigation fires
• Added isWorkoutActive guard to RoutineFlowState.Complete handler (matching the guard already on SetReady)
• Added launchSingleTop = true to RoutineComplete navigation to prevent duplicate backstack entries

Same race existed in ActiveSessionEngine.startNextSetOrExercise() — fixed there too.

Secondary Bug: Profile Deletion Crash

DeleteProfileDialog launched deleteProfile() with zero error handling. On iOS/Kotlin Native, unhandled exceptions in scope.launch call abort() → SIGABRT. Post-deletion gamification recompute (getRpgInput) also had no try-catch.

Fix: Added try-catch with CancellationException rethrow to both the dialog and the repository method.