Skip to content

It's now possible to select the repos and issues - #12

Merged
rajikaimal merged 1 commit into
99x:masterfrom
fdiogo:cli
Oct 20, 2016
Merged

rajikaimal merged 1 commit into
99x:masterfrom
fdiogo:cli

Conversation

@fdiogo

@fdiogo fdiogo commented Oct 20, 2016

Copy link
Copy Markdown
Contributor

I added the inquirer package which really eases the process of reading input from the user. Hope you guys like it.

It's now possible to select the repositories you're interested in and then select from the combined issues of those repositories. Now it always tries to create a label and use that newly created label.

For future changes, I'll create actual models we can use so we can easily control these edge cases.

Added inquirer.js to replace readline-sync
Used bluebird's coroutine API
@rajikaimal

Copy link
Copy Markdown
Contributor

Great work ! Nice to see inquirer added to the package. Hope you did a functional test with this PR.

@rajikaimal
rajikaimal merged commit 318d34e into 99x:master Oct 20, 2016
@rajikaimal

rajikaimal commented Oct 20, 2016 •

Copy link
Copy Markdown
Contributor

Did a functional test, works fine. However I found few issues.

  • if the user doesn't select any repository map function won't work. Exception should be handled.
  • if a label already exists it gives out the whole error json. It would be great if only the error is shown.

Hope you can work on these issues with another PR.
Thanks.

@fdiogo

fdiogo commented Oct 20, 2016

Copy link
Copy Markdown
Contributor Author

Thanks for the quick reply. I did notice the json error but not the map issue. Will work on it. Thanks a lot for the feedback!

@rajikaimal

Copy link
Copy Markdown
Contributor

Great !

@fdiogo fdiogo mentioned this pull request Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants