[fix] fix update-flake-dependencies failures#638
Open
scottisloud wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
#639 suggests the workflow logic is now correct, however, the commits it produces aren't signed. Investigating..... |
Contributor
Author
|
Ah, okay it looks like commit bafbf36 switched from a GITHUB_TOKEN to a PAT. However, commits by automations using a PAT are not signed, and since that swap, we've never had signed commits from this automation. (I assume the switch from a GH token to a PAT was intended to work around GH's suppression of A few ways forward that I'll raise internally. |
Contributor
Author
|
This is blocked until a new GH app is approved, which would allow workloads to make signed commits and PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
automation/update-flake-dependenciesbranch, rather than the previous logic which checked whether a branch of that name exists.Background
update-flake-dependencies would only open a PR with the updated flake.lock file if a branch called
automation/update-flake-dependenciesdid not exist. Since that branch was not reliably deleted, and hasn't been for years, the workflow would find the branch and thus not open a PR.