Skip to content

Checking whether installer is latest shouldn't be critical to installer startup #151

Description

@drojf

Currently, if the installer fails to check if the installre is latest (see below link), it won't startup.

Since this is not important, the installer should just print any errors, and assume the installer is up-to-date (or have a special screen to tell the user installer might not be up to date)

python-patcher/common.py

Lines 269 to 281 in 5585ceb

@staticmethod
def loadInstallerLatestStatus():
latestVersion = getLatestInstallerVersion()
currentVersion = Globals.GIT_TAG
if currentVersion is None or latestVersion is None:
Globals.INSTALLER_IS_LATEST = (None, "WARNING: Version status unknown. Current: {} Latest: {}".format(currentVersion, latestVersion))
elif latestVersion == currentVersion:
Globals.INSTALLER_IS_LATEST = (True, "Installer is latest version: {}".format(currentVersion))
else:
Globals.INSTALLER_IS_LATEST = (False, "WARNING: This installer [{}] is outdated. Latest installer is [{}]".format(currentVersion, latestVersion))
print("> {}".format(Globals.INSTALLER_IS_LATEST[1]))

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions