Repository navigation
fix(ui): model provider toasts — silent delete success, readable add-models plural - #29
Merged
Merged
Conversation
…models plural - Deleting a model no longer shows pending/success toasts; failures still do. - Replace ICU plural messages (unsupported by formatMessage) with .one/.other keys. - Add a locale test that rejects ICU plural/select syntax.
This was referenced Oct 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{count, plural, one {# model} other {# models}}template, becauseIntlProvider.formatMessageonly substitutes{key}placeholders. Replaced the three "add models" messages with.one/.otherkeys selected by count (en-US and zh-CN).localeMessagesFormat.test.ts, which fails if any locale message uses ICU plural/select syntax.Testing
pnpm typecheck: passpnpm lint: 0 errors (80 existing warnings)pnpm architecture:check --changed: 0 new violationspackages/uitestslocaleMessagesFormatandproviderDetailFeedback: pass; the new test fails on the old locale files