Replace areAnyConditionsAClass manual loop with Conditions::hasCondition()

Delegates condition checking to PHPCSUtils which provides the same
logic with an added isset($tokens[$ptr]) guard.

Author: sirbrillig

VariableAnalysis/Lib/Helpers.php

@@ -10,6 +10,7 @@
 use VariableAnalysis\Lib\ScopeType;
 use VariableAnalysis\Lib\VariableInfo;
 use PHP_CodeSniffer\Util\Tokens;
+use PHPCSUtils\Utils\Conditions;
 use PHPCSUtils\Utils\Context;
 use PHPCSUtils\Utils\Lists;
 use PHPCSUtils\Utils\Parentheses;
@@ -101,24 +102,19 @@ public static function findContainingOpeningBracket(File $phpcsFile, $stackPtr)
 	}
 
 	/**
-	 * @param array{conditions: (int|string)[], content: string} $token
+	 * @param File $phpcsFile
+	 * @param int  $stackPtr
 	 *
 	 * @return bool
 	 */
-	public static function areAnyConditionsAClass(array $token)
+	public static function areAnyConditionsAClass(File $phpcsFile, $stackPtr)
 	{
-		$conditions = $token['conditions'];
 		$classlikeCodes = [T_CLASS, T_ANON_CLASS, T_TRAIT];
 		if (defined('T_ENUM')) {
 			$classlikeCodes[] = T_ENUM;
 		}
 		$classlikeCodes[] = 'PHPCS_T_ENUM';
-		foreach (array_reverse($conditions, true) as $scopeCode) {
-			if (in_array($scopeCode, $classlikeCodes, true)) {
-				return true;
-			}
-		}
-		return false;
+		return Conditions::hasCondition($phpcsFile, $stackPtr, $classlikeCodes);
 	}
 
 	/**

VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php

@@ -892,7 +892,7 @@ protected function processVariableAsClassProperty(File $phpcsFile, $stackPtr)
 		/** @var array{conditions?: (int|string)[], content?: string}|null */
 		$token = $tokens[$stackPtr];
 		if ($token && !empty($token['conditions']) && !empty($token['content']) && !Helpers::areConditionsWithinFunctionBeforeClass($token)) {
-			return Helpers::areAnyConditionsAClass($token);
+			return Helpers::areAnyConditionsAClass($phpcsFile, $stackPtr);
 		}
 		return false;
 	}
@@ -1105,7 +1105,7 @@ protected function processVariableAsStaticOutsideClass(File $phpcsFile, $stackPt
 		}
 		$errorClass = $code === T_SELF ? 'SelfOutsideClass' : 'StaticOutsideClass';
 		$staticRefType = $code === T_SELF ? 'self::' : 'static::';
-		if (!empty($token['conditions']) && !empty($token['content']) && Helpers::areAnyConditionsAClass($token)) {
+		if ($token && !empty($token['content']) && Helpers::areAnyConditionsAClass($phpcsFile, $stackPtr)) {
 			return false;
 		}
 		$phpcsFile->addError(