Skip to content

fix: harden localhost server boundary - #175

Merged
rowkav09 merged 3 commits into
mainfrom
fix/173-loopback-security-headers
Sep 22, 2026
Merged

rowkav09 merged 3 commits into
mainfrom
fix/173-loopback-security-headers

Conversation

@rowkav09

Copy link
Copy Markdown
Member

/mira pause

A bounded first localhost UI hardening slice for #173.

What changed

  • reject non-loopback bind addresses before creating the server
  • accept loopback IPv4, IPv6 and localhost only
  • add CSP, frame denial, no-sniff, referrer and same-origin resource policy headers centrally
  • keep all adapter responses uncached by default

Why

The setup/status UI must not become reachable on the LAN or embeddable/executable by an untrusted website.

Checks

  • hostile bind and header fixtures
  • npm test
  • npm run check

Start #173 by failing closed on non-loopback binds and adding browser security headers at the Node server boundary.
@rowkav09

Copy link
Copy Markdown
Member Author

/mira pause

@mira-reviewer-rk

mira-reviewer-rk Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Mira PR Walkthrough


❌ Review failed — click for details

The code review failed to complete due to an unexpected error.

Stage: Code review
Error type: LLMError
Message: LLM tool-call failed

Added security headers and tests for loopback host validation.
@github-actions github-actions Bot added size:M and removed size:S labels Sep 22, 2026
@rowkav09 rowkav09 added the mira-paused Pause automatic Mira reviews on this pull request label Sep 22, 2026
@rowkav09
rowkav09 merged commit fb668c8 into main Sep 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:server mira-paused Pause automatic Mira reviews on this pull request size:M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant