Repository navigation
Export LayoutResults::operator== (#59997) - #59997
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@lenaic has exported this pull request. If you are a Meta employee, you can view the originating Diff in D131770771. |
javache
approved these changes
Nov 13, 2026
javache
left a comment
javache
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary: `yoga::Node` is exported from the Yoga library and hands out its `LayoutResults` through `getLayout()`, but `LayoutResults::operator==` is defined out of line and not exported. Code outside Yoga that compares two layout results fails to link wherever Yoga is built as a shared library with hidden visibility. Mark the operator `YG_EXPORT` so React Native can compare a node's layout results with those of the node it replaces. Changelog: [Internal] Reviewed By: javache Differential Revision: D131770771
meta-codesync
Bot
changed the title
LayoutResults::operator==LayoutResults::operator== (#59997)
lenaic
force-pushed
the
export-D131770771
branch
from
November 13, 2026 14:37
8214289 to
978d5dc
Compare
Visual regression1 visual difference(s) at ios
|
| Expected | Captured |
|---|---|
 |
 |
meta-codesync Bot
pushed a commit
to react/yoga
that referenced
this pull request
Nov 13, 2026
Summary: X-link: react/react-native#59997 `yoga::Node` is exported from the Yoga library and hands out its `LayoutResults` through `getLayout()`, but `LayoutResults::operator==` is defined out of line and not exported. Code outside Yoga that compares two layout results fails to link wherever Yoga is built as a shared library with hidden visibility. Mark the operator `YG_EXPORT` so React Native can compare a node's layout results with those of the node it replaces. Changelog: [Internal] Reviewed By: javache Differential Revision: D131770771 Pull Request resolved: #2091
meta-codesync Bot
pushed a commit
to meta/litho
that referenced
this pull request
Nov 13, 2026
Summary: X-link: react/yoga#2091 X-link: react/react-native#59997 `yoga::Node` is exported from the Yoga library and hands out its `LayoutResults` through `getLayout()`, but `LayoutResults::operator==` is defined out of line and not exported. Code outside Yoga that compares two layout results fails to link wherever Yoga is built as a shared library with hidden visibility. Mark the operator `YG_EXPORT` so React Native can compare a node's layout results with those of the node it replaces. Changelog: [Internal] Reviewed By: javache Differential Revision: D131770771 fbshipit-source-id: 9b379ff705881bee3fc6470402c2c3fe73de6ec0
Collaborator
|
This pull request was successfully merged by @lenaic in ad2e8f2 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
yoga::Nodeis exported from the Yoga library and hands out itsLayoutResultsthroughgetLayout(), butLayoutResults::operator==is defined out of line and not exported. Code outside Yoga that compares two layout results fails to link wherever Yoga is built as a shared library with hidden visibility.Mark the operator
YG_EXPORTso React Native can compare a node's layout results with those of the node it replaces.Changelog: [Internal]
Reviewed By: javache
Differential Revision: D131770771