From 385042726d49d45702fd7ca872c514226e987281 Mon Sep 17 00:00:00 2001 From: Raj D <25481060+radroid@users.noreply.github.com> Date: Sun, 20 Sep 2026 07:38:14 -0400 Subject: [PATCH] fix(coil): scripts typecheck passes on effect rc.115 The sync merge (#153) bumped effect to rc.115, which renamed the unstable CLI helpers Flag.string/Flag.boolean to Flag.String/Flag.Boolean. verify-mac-signature still used the old names, so the scripts package failed typecheck on main and the release was withheld. sync-upstream.test.ts also tripped the nodeBuiltinImport diagnostic; it now carries the same per-file opt-out header upstream puts on its own scripts tests that shell out to real processes. Co-Authored-By: Claude Fable 5.1 --- scripts/coil/sync-upstream.test.ts | 1 + scripts/coil/verify-mac-signature.ts | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/scripts/coil/sync-upstream.test.ts b/scripts/coil/sync-upstream.test.ts index e83fe4d2961e..638f97bd879e 100644 --- a/scripts/coil/sync-upstream.test.ts +++ b/scripts/coil/sync-upstream.test.ts @@ -1,3 +1,4 @@ +// @effect-diagnostics nodeBuiltinImport:off - Runs the real sync-upstream.sh against disposable on-disk git repos. import { assert, it } from "@effect/vitest"; import * as NodeChildProcess from "node:child_process"; import * as NodeFS from "node:fs"; diff --git a/scripts/coil/verify-mac-signature.ts b/scripts/coil/verify-mac-signature.ts index 17ac0d510dff..38ee816022ca 100644 --- a/scripts/coil/verify-mac-signature.ts +++ b/scripts/coil/verify-mac-signature.ts @@ -275,26 +275,26 @@ const verifyMacSignature = Effect.fn("verifyMacSignature")(function* (input: { export const verifyMacSignatureCommand = Command.make( "verify-mac-signature", { - artifact: Flag.string("artifact").pipe( + artifact: Flag.String("artifact").pipe( Flag.withDescription("Path to the built .dmg, or to a .app bundle."), ), - expectRequirementFile: Flag.string("expect-requirement-file").pipe( + expectRequirementFile: Flag.String("expect-requirement-file").pipe( Flag.withDescription( "File holding the designated requirement every release must match, byte for byte.", ), Flag.optional, ), - writeRequirementFile: Flag.string("write-requirement-file").pipe( + writeRequirementFile: Flag.String("write-requirement-file").pipe( Flag.withDescription( "Record this artifact's designated requirement to a file (only when the verdict is stable).", ), Flag.optional, ), - expectAuthority: Flag.string("expect-authority").pipe( + expectAuthority: Flag.String("expect-authority").pipe( Flag.withDescription("Signing identity name the leaf Authority must equal."), Flag.optional, ), - allowUnsigned: Flag.boolean("allow-unsigned").pipe( + allowUnsigned: Flag.Boolean("allow-unsigned").pipe( Flag.withDescription( "Warn instead of failing when no signing identity was used. Never allows a CHANGED identity.", ),