From ea6cc0d54df8f6ff5c1753984f00087dabdfdd32 Mon Sep 17 00:00:00 2001 From: QuantCode Agent Date: Mon, 31 Aug 2026 16:23:50 +0000 Subject: [PATCH] fix: repair failing tests and type errors across api and shared packages - Implement paginate in shared (was a throwing stub) with input normalisation - Import badRequest in users route (ReferenceError caused 500 instead of 400) - Rename User.userName -> username for cross-package consistency with tests - Fix auth middleware public-method allow-list casing (POST was 401) - Reference bun-types in tsconfig to resolve bun:test and process type errors --- packages/api/src/middleware/auth.ts | 15 ++++++--------- packages/api/src/routes/users.ts | 6 +----- packages/shared/src/types.ts | 6 +----- packages/shared/src/utils/pagination.ts | 14 +++++++++++--- tsconfig.json | 1 + 5 files changed, 20 insertions(+), 22 deletions(-) diff --git a/packages/api/src/middleware/auth.ts b/packages/api/src/middleware/auth.ts index dde32d9..ffc0991 100644 --- a/packages/api/src/middleware/auth.ts +++ b/packages/api/src/middleware/auth.ts @@ -7,17 +7,14 @@ import type { MiddlewareHandler } from "hono" * GET, POST → public (no token required) * PUT, DELETE, PATCH → require Bearer token * - * BUG: The allow-list check uses `'post'` (lowercase) instead of `'POST'`. - * HTTP methods are always uppercase per RFC 7231, so POST is never matched - * as a public method — POST requests incorrectly require a token. - * - * Fix: change `'post'` to `'POST'` in the public methods array. + * The incoming method is upper-cased before matching. HTTP methods are + * case-sensitive and uppercase per RFC 7231, but normalising means the + * allow-list can never silently fail to match on casing alone. */ -export const authMiddleware: MiddlewareHandler = async (c, next) => { - // BUG: 'post' should be 'POST' — POST is never treated as public - const publicMethods = ["GET", "post"] +const PUBLIC_METHODS = ["GET", "POST"] - if (publicMethods.includes(c.req.method)) { +export const authMiddleware: MiddlewareHandler = async (c, next) => { + if (PUBLIC_METHODS.includes(c.req.method.toUpperCase())) { return next() } diff --git a/packages/api/src/routes/users.ts b/packages/api/src/routes/users.ts index 53e605a..8056ce3 100644 --- a/packages/api/src/routes/users.ts +++ b/packages/api/src/routes/users.ts @@ -1,9 +1,6 @@ import { Hono } from "hono" import { db } from "../lib/db" -import { notFound } from "../lib/errors" -// BUG: missing import — `badRequest` is used below but not imported here. -// This causes a ReferenceError at runtime when POST /users is called with invalid data. -// Fix: add `badRequest` to the import from "../lib/errors" +import { notFound, badRequest } from "../lib/errors" const router = new Hono() @@ -20,7 +17,6 @@ router.get("/:id", (c) => { router.post("/", async (c) => { const body = await c.req.json().catch(() => null) if (!body || !body.username || !body.email) { - // BUG: badRequest is not imported — this will throw ReferenceError return badRequest(c, "username and email are required") } const user = db.users.create({ username: body.username, email: body.email }) diff --git a/packages/shared/src/types.ts b/packages/shared/src/types.ts index a2a1377..b6f7974 100644 --- a/packages/shared/src/types.ts +++ b/packages/shared/src/types.ts @@ -1,14 +1,10 @@ /** * Shared types used by both the API and any consumers. - * - * BUG: The field is named `userName` here but the API routes reference `username` - * (lowercase n). This causes a type error in routes/users.ts and a runtime - * mismatch when serialising responses. */ export type User = { id: string - userName: string // BUG: should be `username` to match API usage + username: string email: string createdAt: string } diff --git a/packages/shared/src/utils/pagination.ts b/packages/shared/src/utils/pagination.ts index 12f8062..60ddeac 100644 --- a/packages/shared/src/utils/pagination.ts +++ b/packages/shared/src/utils/pagination.ts @@ -7,9 +7,17 @@ import type { PaginatedResponse } from "../types" * @param page 1-indexed page number * @param size Number of items per page * - * TODO: implement this function — it is currently a stub. - * The test in packages/shared/test/pagination.test.ts exercises the full contract. + * Out-of-range pages yield an empty `data` array. Non-positive or non-finite + * `page`/`size` values are normalised so an untrusted query parameter can never + * produce a negative slice offset (which would return unintended items). */ export function paginate(items: T[], page: number, size: number): PaginatedResponse { - throw new Error("not implemented") + const total = items.length + const pageSize = Number.isFinite(size) && size > 0 ? Math.floor(size) : 0 + const currentPage = Number.isFinite(page) && page > 0 ? Math.floor(page) : 1 + const totalPages = pageSize > 0 ? Math.ceil(total / pageSize) : 0 + const start = (currentPage - 1) * pageSize + const data = pageSize > 0 ? items.slice(start, start + pageSize) : [] + + return { data, page: currentPage, pageSize, total, totalPages } } diff --git a/tsconfig.json b/tsconfig.json index 53de6fd..b4bf326 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -5,6 +5,7 @@ "moduleResolution": "bundler", "strict": true, "skipLibCheck": true, + "types": ["bun-types"], "paths": { "@e2e/shared": ["./packages/shared/src/index.ts"] }