ext/intl: GH-20255 IntlDateFormatter adding proleptic gregorian calen… - #21101
ext/intl: GH-20255 IntlDateFormatter adding proleptic gregorian calen…#21101devnexen wants to merge 2 commits into
Conversation
…lendar support. To be consistent with DateImmutable class, we add the possibility to set the calendar in a (real) proleptic gregorian via a new flag constant. For now, intention needs to be clear but can be made default eventually.
|
ping :) |
|
I don't know anything about calendars or dates really. Asking Derick to review this instead. |
|
@devnexen Somehow, this commit fails the build for the benchmark suite, see https://github.com/php/php-src/actions/runs/30867397842/job/91862130279#step:16:13190 . I used "bisecting" locally, and I ended up at this commit that first failed compilation (actually as far as I can see, the configure script fails). Unfortunately, I don't see based on the diff what could have gone wrong, nor I found anything useful in the logs. Do you have any idea how what may be the problem? |
|
I don't see any thing that could go wrong in this PR. I doubt there are other reasons. |
|
The first thing coming up to my head is missing header maybe. e.g. |
|
@LamentXU123 feel free to make a PR. Cheers ! |
This fixes #21101 (comment) Some extreme build environments happen to get std::numeric_limits through transitive includes. So we need to put a Include manually Co-authored-by: David Carlier <devnexen@gmail.com>
|
@LamentXU123 @devnexen Thanks for the fix, it worked! :) |
5 participants
…dar support.
To be consistent with DateImmutable class, we add the possibility to set the calendar in a (real) proleptic gregorian via a new flag constant. For now, intention needs to be clear but can be made default eventually.