Skip to content

chore(CalendarMonth): Include OUIAProps for CalendarMonth - #12593

Open
mshriver wants to merge 1 commit into
patternfly:mainfrom
mshriver:calendar-month-ouia
Open

chore(CalendarMonth): Include OUIAProps for CalendarMonth#12593
mshriver wants to merge 1 commit into
patternfly:mainfrom
mshriver:calendar-month-ouia

Conversation

@mshriver

@mshriver mshriver commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Add OUIA attribute support to CalendarMonth for better test automation.

What:
Closes #12592

Summary by CodeRabbit

  • New Features
    • Added Open UI Automation support to the Calendar Month component.
    • Added optional automation properties for a custom component ID and safety behavior, enabled by default.
    • Included component type, custom ID, and safety state in rendered automation metadata.
  • Tests
    • Added coverage for Open UI Automation attributes and default behavior.
  • Documentation
    • Listed Calendar Month as a supported component in the Open UI Automation guide.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ce1247bf-8daf-4207-8348-8a484b213e6a

📥 Commits

Reviewing files that changed from the base of the PR and between 759a598 and 5bef644.

⛔ Files ignored due to path filters (7)
  • packages/react-core/src/components/DatePicker/__tests__/__snapshots__/DatePicker.test.tsx.snap is excluded by !**/*.snap
  • packages/react-table/src/deprecated/components/Table/__tests__/__snapshots__/Table.test.tsx.snap is excluded by !**/*.snap
  • packages/react-templates/src/components/Dropdown/__tests__/__snapshots__/SimpleDropdown.test.tsx.snap is excluded by !**/*.snap
  • packages/react-templates/src/components/Select/__tests__/__snapshots__/CheckboxSelectSnapshots.test.tsx.snap is excluded by !**/*.snap
  • packages/react-templates/src/components/Select/__tests__/__snapshots__/MultiTypeaheadSelect.test.tsx.snap is excluded by !**/*.snap
  • packages/react-templates/src/components/Select/__tests__/__snapshots__/SimpleSelect.test.tsx.snap is excluded by !**/*.snap
  • packages/react-templates/src/components/Select/__tests__/__snapshots__/TypeaheadSelect.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (3)
  • packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx
  • packages/react-core/src/components/CalendarMonth/__tests__/CalendarMonth.test.tsx
  • packages/react-core/src/helpers/OUIA/OUIA.md
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/react-core/src/helpers/OUIA/OUIA.md
  • packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx

Walkthrough

CalendarMonth now accepts OUIA props, renders the corresponding data-ouia-* attributes, includes attribute tests, and is listed in the OUIA developer guide.

Changes

CalendarMonth OUIA integration

Layer / File(s) Summary
OUIA props and root rendering
packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx
CalendarMonth accepts ouiaId and ouiaSafe, computes OUIA props, and applies them to its root element.
OUIA validation and documentation
packages/react-core/src/components/CalendarMonth/__tests__/CalendarMonth.test.tsx, packages/react-core/src/helpers/OUIA/OUIA.md
Tests verify the OUIA component ID, component type, default safety value, and explicit safety override. The guide lists CalendarMonth as supported.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: kmcfaul, thatblindgeye, rebeccaalpert

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the addition of OUIA support to CalendarMonth.
Linked Issues check ✅ Passed The changes add OUIA props, tests, and documentation for CalendarMonth, satisfying issue #12592.
Out of Scope Changes check ✅ Passed All reviewed changes directly support CalendarMonth OUIA integration and its validation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rebeccaalpert rebeccaalpert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about the snapshot test - any particular reason for it?

Comment thread packages/react-core/src/components/CalendarMonth/__tests__/CalendarMonth.test.tsx Outdated
Add OUIA attribute support to CalendarMonth for better test automation.

Co-authored-by: Cursor <cursoragent@cursor.com>
@mshriver
mshriver force-pushed the calendar-month-ouia branch from 18d8c90 to 5bef644 Compare August 6, 2026 13:36
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@mshriver
mshriver requested a review from rebeccaalpert August 6, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CalendarMonth missing OUIA Support

2 participants