From 10de166e3ac6126d7c572bad121ef59e13089f04 Mon Sep 17 00:00:00 2001 From: Matthias Feurer Date: Fri, 24 Feb 2023 11:36:58 +0100 Subject: [PATCH 1/5] Install custom numpy version for specific combination of Python3.8 and numpy --- .github/workflows/test.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 782b6e0a3..60bbb03f6 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -72,6 +72,11 @@ jobs: - name: Install scikit-learn ${{ matrix.scikit-learn }} run: | pip install scikit-learn==${{ matrix.scikit-learn }} + - name: Install numpy for Python 3.8 + # Python 3.8 & scikit-learn<0.24 requires numpy<=1.23.5 + if: ${{ matrix.python-version }} == 3.8 && contains(fromJSON('["0.23.1", "0.22.2", "0.21.2"]'), matrix.scikit-learn) + run: | + pip install numpy==1.23.5 - name: Install scipy ${{ matrix.scipy }} if: ${{ matrix.scipy }} run: | From 85ed66fdf78bd3dd26c30f63e81bedefd10b96d8 Mon Sep 17 00:00:00 2001 From: Matthias Feurer Date: Fri, 24 Feb 2023 11:44:33 +0100 Subject: [PATCH 2/5] Debug output --- .github/workflows/test.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 60bbb03f6..a0f6d1bb0 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -74,8 +74,11 @@ jobs: pip install scikit-learn==${{ matrix.scikit-learn }} - name: Install numpy for Python 3.8 # Python 3.8 & scikit-learn<0.24 requires numpy<=1.23.5 - if: ${{ matrix.python-version }} == 3.8 && contains(fromJSON('["0.23.1", "0.22.2", "0.21.2"]'), matrix.scikit-learn) - run: | + if: ${{ matrix.python-version }} == '3.8' && contains(fromJSON('["0.23.1", "0.22.2", "0.21.2"]'), matrix.scikit-learn) + run: | + echo ${{ matrix.python-version }} == '3.8' + echo ${{ matrix.python-version }} + echo contains(fromJSON('["0.23.1", "0.22.2", "0.21.2"]'), matrix.scikit-learn) pip install numpy==1.23.5 - name: Install scipy ${{ matrix.scipy }} if: ${{ matrix.scipy }} From 792aa0c8f9fb5f7cf2779983b42b0aa6f3c22f61 Mon Sep 17 00:00:00 2001 From: Matthias Feurer Date: Fri, 24 Feb 2023 13:44:22 +0100 Subject: [PATCH 3/5] Change syntax --- .github/workflows/test.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a0f6d1bb0..03b353dd9 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -74,11 +74,10 @@ jobs: pip install scikit-learn==${{ matrix.scikit-learn }} - name: Install numpy for Python 3.8 # Python 3.8 & scikit-learn<0.24 requires numpy<=1.23.5 - if: ${{ matrix.python-version }} == '3.8' && contains(fromJSON('["0.23.1", "0.22.2", "0.21.2"]'), matrix.scikit-learn) + if: ${{ matrix.python-version == '3.8' && contains(fromJSON('["0.23.1", "0.22.2", "0.21.2"]'), matrix.scikit-learn) }} run: | echo ${{ matrix.python-version }} == '3.8' echo ${{ matrix.python-version }} - echo contains(fromJSON('["0.23.1", "0.22.2", "0.21.2"]'), matrix.scikit-learn) pip install numpy==1.23.5 - name: Install scipy ${{ matrix.scipy }} if: ${{ matrix.scipy }} From 4f223e91102c09eb15709040251c7f4305ec2c91 Mon Sep 17 00:00:00 2001 From: Matthias Feurer Date: Fri, 24 Feb 2023 14:28:51 +0100 Subject: [PATCH 4/5] move to coverage action v3 --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 03b353dd9..b981b49d8 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -112,7 +112,7 @@ jobs: fi - name: Upload coverage if: matrix.code-cov && always() - uses: codecov/codecov-action@v1 + uses: codecov/codecov-action@v3 with: files: coverage.xml fail_ci_if_error: true From a02e1ddba70f40a975b7edd60a5ee5d30a36a88b Mon Sep 17 00:00:00 2001 From: Matthias Feurer Date: Wed, 1 Mar 2023 08:34:18 +0100 Subject: [PATCH 5/5] Remove test output --- .github/workflows/test.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b981b49d8..974147ed3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -76,8 +76,6 @@ jobs: # Python 3.8 & scikit-learn<0.24 requires numpy<=1.23.5 if: ${{ matrix.python-version == '3.8' && contains(fromJSON('["0.23.1", "0.22.2", "0.21.2"]'), matrix.scikit-learn) }} run: | - echo ${{ matrix.python-version }} == '3.8' - echo ${{ matrix.python-version }} pip install numpy==1.23.5 - name: Install scipy ${{ matrix.scipy }} if: ${{ matrix.scipy }}