From c2f9c2e76ca195f063b2a9c5ddb1b4073f58484d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tobias=20Nie=C3=9Fen?= <tniessen@tnie.de>
Date: Thu, 28 Jul 2022 10:18:43 +0000
Subject: [PATCH] test: fix multiple incorrect mustNotCall() uses

This does not fix occurrences in test/parallel/test-dns-* because those
tests contain unrelated pre-existing bugs that would cause the tests to
fail with this fix. This unrelated bug in those tests should be fixed
separately before the use of mustNotCall() can be fixed in those files.
---
 test/parallel/test-console-log-stdio-broken-dest.js       | 2 +-
 test/parallel/test-http2-https-fallback.js                | 2 +-
 test/parallel/test-stream-readable-reading-readingMore.js | 2 +-
 test/parallel/test-zlib-invalid-input.js                  | 2 +-
 test/parallel/test-zlib-sync-no-event.js                  | 4 ++--
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/test/parallel/test-console-log-stdio-broken-dest.js b/test/parallel/test-console-log-stdio-broken-dest.js
index d29e8ee5173b..bdd1b7942745 100644
--- a/test/parallel/test-console-log-stdio-broken-dest.js
+++ b/test/parallel/test-console-log-stdio-broken-dest.js
@@ -15,7 +15,7 @@ const stream = new Writable({
 });
 const myConsole = new Console(stream, stream);
 
-process.on('warning', common.mustNotCall);
+process.on('warning', common.mustNotCall());
 
 stream.cork();
 for (let i = 0; i < EventEmitter.defaultMaxListeners + 1; i++) {
diff --git a/test/parallel/test-http2-https-fallback.js b/test/parallel/test-http2-https-fallback.js
index 16879b05f12c..2e85b8901781 100644
--- a/test/parallel/test-http2-https-fallback.js
+++ b/test/parallel/test-http2-https-fallback.js
@@ -141,7 +141,7 @@ function onSession(session, next) {
 
     function testNoTls() {
       // HTTP/1.1 client
-      get(Object.assign(parse(origin), clientOptions), common.mustNotCall)
+      get(Object.assign(parse(origin), clientOptions), common.mustNotCall())
         .on('error', common.mustCall(cleanup))
         .on('error', common.mustCall(testWrongALPN))
         .end();
diff --git a/test/parallel/test-stream-readable-reading-readingMore.js b/test/parallel/test-stream-readable-reading-readingMore.js
index 968bf5c63ae0..5e39c86dcba5 100644
--- a/test/parallel/test-stream-readable-reading-readingMore.js
+++ b/test/parallel/test-stream-readable-reading-readingMore.js
@@ -124,7 +124,7 @@ const Readable = require('stream').Readable;
   assert.strictEqual(state.reading, false);
   assert.strictEqual(state.readingMore, false);
 
-  const onReadable = common.mustNotCall;
+  const onReadable = common.mustNotCall();
 
   readable.on('readable', onReadable);
 
diff --git a/test/parallel/test-zlib-invalid-input.js b/test/parallel/test-zlib-invalid-input.js
index 67793984a991..7aa44dfe7090 100644
--- a/test/parallel/test-zlib-invalid-input.js
+++ b/test/parallel/test-zlib-invalid-input.js
@@ -53,7 +53,7 @@ nonStringInputs.forEach(common.mustCall((input) => {
 
 unzips.forEach(common.mustCall((uz, i) => {
   uz.on('error', common.mustCall());
-  uz.on('end', common.mustNotCall);
+  uz.on('end', common.mustNotCall());
 
   // This will trigger error event
   uz.write('this is not valid compressed data.');
diff --git a/test/parallel/test-zlib-sync-no-event.js b/test/parallel/test-zlib-sync-no-event.js
index 479aa1c411b0..e7f25c8476ee 100644
--- a/test/parallel/test-zlib-sync-no-event.js
+++ b/test/parallel/test-zlib-sync-no-event.js
@@ -7,12 +7,12 @@ const message = 'Come on, Fhqwhgads.';
 const buffer = Buffer.from(message);
 
 const zipper = new zlib.Gzip();
-zipper.on('close', common.mustNotCall);
+zipper.on('close', common.mustNotCall());
 
 const zipped = zipper._processChunk(buffer, zlib.constants.Z_FINISH);
 
 const unzipper = new zlib.Gunzip();
-unzipper.on('close', common.mustNotCall);
+unzipper.on('close', common.mustNotCall());
 
 const unzipped = unzipper._processChunk(zipped, zlib.constants.Z_FINISH);
 assert.notStrictEqual(zipped.toString(), message);