From d0fcf549fe8f2c14803545ea182474d3cbc81000 Mon Sep 17 00:00:00 2001 From: hilram7 <212961752+hilram7@users.noreply.github.com> Date: Wed, 12 Aug 2026 02:30:11 -0700 Subject: [PATCH 01/20] Dedup KB skill rulebook: extract shared rules into kb-editing-conventions.md derek, kb-pr-open, and kb-pr-review each independently inlined Derek's areas table, title-format rules, and the callout-severity mapping, requiring N synchronized manual edits per rule change (root cause of most add-kb-skills PR #1358 review rounds). Extend the existing kb-editing-conventions.md sections (callouts, bolding, links, titles) and add new ones (frontmatter, article-type identification, article structure, images) as the single source; all three skills now read from it instead of duplicating. Also reconciles the knowledge_article_id policy (kb-pr-review allowed proposing removal of a placeholder value; kb-pr-open never did) to kb-pr-open's never-remove policy, fixes kb-pr-review's stale BoilerplateCrossRef note (the Vale rule is unreachable on docs/kb/ files), and syncs wording drift in the kb-editing-conventions scan table and cross-section consistency table between the two PR skills. Addresses netwrix-corp/docs-kb-staging#131. Generated with AI Co-Authored-By: Claude Code --- .claude/references/kb-editing-conventions.md | 139 +++++++++++++++++-- .claude/skills/derek/SKILL.md | 115 +++------------ .claude/skills/kb-pr-open/SKILL.md | 88 +++--------- .claude/skills/kb-pr-review/SKILL.md | 94 +++++-------- 4 files changed, 210 insertions(+), 226 deletions(-) diff --git a/.claude/references/kb-editing-conventions.md b/.claude/references/kb-editing-conventions.md index ac48e01bba..10809b503b 100644 --- a/.claude/references/kb-editing-conventions.md +++ b/.claude/references/kb-editing-conventions.md @@ -1,8 +1,8 @@ # KB Editing Conventions -Comprehensive KB editing rulebook covering structure, step condensation, list types, sentence-level rules, callouts, bolding, overview quality, links, placeholders, formatting, cross-section consistency, and titles. +Comprehensive KB editing rulebook covering frontmatter, article type identification, article structure, structure/step condensation, list types, sentence-level rules, callouts, bolding, overview quality, links, placeholders, formatting, cross-section consistency, titles, and images. -Apply during the `kb-pr-open` preemptive scan and the `kb-pr-review` Derek review pass on every KB batch. This document is the canonical rulebook — both skills reference it rather than duplicating its content. Amend it via PR when a batch surfaces a new pattern. +Apply during the `kb-pr-open` preemptive scan, the `kb-pr-review` review pass, and the `derek` review on every KB batch. This document is the canonical rulebook — `derek`, `kb-pr-open`, and `kb-pr-review` all read it rather than duplicating its content. Amend it via PR when a batch surfaces a new pattern. ## 1. Heading/step structure @@ -12,7 +12,7 @@ Apply during the `kb-pr-open` preemptive scan and the `kb-pr-review` Derek revie - **Gate B — Normalize.** If ≥3 substantive subheadings remain after Gate A **and represent sequential steps of the same procedure**, apply `Step N —