Make PEP 723 metadata diagnostics actionable - #1769
Merged
Stella Huang (StellaHuang95) merged 2 commits intoSep 8, 2026
Merged
Conversation
Stella Huang (StellaHuang95)
added
the
bug
Stella Huang (StellaHuang95)
force-pushed
the
fixInlineScriptIssues
branch
from
September 8, 2026 20:51
75321f4 to
544f6af
Compare
A malformed PEP 723 block logged a warning that named no file, printed ten
frames of minified bundle internals, and reported a row index into the
reconstructed TOML rather than a line in the script. It read like an
extension crash while telling the user neither which file was wrong nor
where.
inline script metadata: failed to parse TOML in `# /// script` block:
[TomlError: Unterminated string at row 1, col 27, pos 26:
1> requires-python = ">=3.11
at TOMLParser.parseBasicString (dist/extension.js:45477:28)
... 9 more frames
inline script metadata in C:\src\app.py: invalid TOML in the
`# /// script` block (line 2): Unterminated string
Take an optional source label on readInlineScriptMetadata and thread it
through every diagnostic; readInlineScriptMetadataFromFile passes the
script path. Translate the TOML row into a real script line via the known
block offset, drop the payload-relative coordinates and caret excerpt, and
move the full error (with its stack) to the debug level for anyone
diagnosing the parser itself. Parsing behaviour is unchanged.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Stella Huang (StellaHuang95)
force-pushed
the
fixInlineScriptIssues
branch
from
September 8, 2026 21:14
544f6af to
cd7d214
Compare
Contributor
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
Contributor
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Summary: Podman setup was declined or unavailable; isolated test execution was skipped. Test runs: none recorded. |
Rich Chiodo (rchiodo)
approved these changes
Sep 8, 2026
Rich Chiodo (rchiodo)
left a comment
Rich Chiodo (rchiodo)
left a comment
Contributor
There was a problem hiding this comment.
Approved via Review Center.
Rich Chiodo (rchiodo)
added
the
review-auto:approved
| */ | ||
| export function readInlineScriptMetadata(scriptText: string): InlineScriptMetadata | undefined { | ||
| export function readInlineScriptMetadata(scriptText: string, source?: string): InlineScriptMetadata | undefined { | ||
| const where = source ? ` in ${source}` : ''; |
Contributor
There was a problem hiding this comment.
Maybe add the space in the consuming strings?
Contributor
Author
There was a problem hiding this comment.
like in line 124 and 129? not sure if it's a good idea to put repetitive code in multiple places thorough, the space is only added when there's actual source exist do the check is done before it being consumed.
| // full error (with stack and excerpt) goes to the debug level for anyone | ||
| // diagnosing the parser itself. | ||
| const tomlRow = getTomlErrorRow(err); | ||
| const at = tomlRow === undefined ? '' : ` (line ${blockStartLine + 1 + tomlRow})`; |
Contributor
There was a problem hiding this comment.
Same here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make PEP 723 inline-script metadata failures easier to diagnose in the Python Environments output:
Parsing acceptance, environment provisioning, and interpreter routing are unchanged. This PR includes both commits from
fixInlineScriptIssues, including the formatting follow-up.