Skip to content

Commit eecb129

Browse files
dgozmanclaude
andauthored
chore: remove onTestPaused from reporters (#43570)
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
1 parent ca7ca36 commit eecb129

25 files changed

Lines changed: 24 additions & 694 deletions

‎packages/playwright/src/cli/testActions.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ function overridesFromOptions(options: { [key: string]: any }): ipc.ConfigCLIOve
116116
globalTimeout: options.globalTimeout ? parseInt(options.globalTimeout, 10) : undefined,
117117
maxFailures: options.x ? 1 : (options.maxFailures ? parseInt(options.maxFailures, 10) : undefined),
118118
outputDir: options.output ? path.resolve(process.cwd(), options.output) : undefined,
119-
pause: !!process.env.PWPAUSE,
120119
quiet: options.quiet ? options.quiet : undefined,
121120
repeatEach: options.repeatEach ? parseInt(options.repeatEach, 10) : undefined,
122121
retries: options.retries ? parseInt(options.retries, 10) : undefined,

‎packages/playwright/src/common/config.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ export class FullConfigInternal {
111111
updateSnapshots: takeFirst(configCLIOverrides.updateSnapshots, userConfig.updateSnapshots, 'default'),
112112
updateSourceMethod: takeFirst(configCLIOverrides.updateSourceMethod, userConfig.updateSourceMethod, 'patch'),
113113
version: packageJSON.version,
114-
workers: resolveWorkers(takeFirst((configCLIOverrides.debug || configCLIOverrides.pause) ? 1 : undefined, configCLIOverrides.workers, userConfig.workers, '50%')),
114+
workers: resolveWorkers(takeFirst(configCLIOverrides.debug ? 1 : undefined, configCLIOverrides.workers, userConfig.workers, '50%')),
115115
webServer: null,
116116
};
117117
for (const key in userConfig) {

‎packages/playwright/src/common/ipc.ts‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ export type ConfigCLIOverrides = {
3131
globalTimeout?: number;
3232
maxFailures?: number;
3333
outputDir?: string;
34-
pause?: boolean;
3534
quiet?: boolean;
3635
repeatEach?: number;
3736
retries?: number;
@@ -96,11 +95,8 @@ export type TestInfoErrorPayload = {
9695
export type TestPausedPayload = {
9796
testId: string;
9897
errors: TestInfoErrorPayload[];
99-
status: TestStatus;
10098
};
10199

102-
export type ResumePayload = {};
103-
104100
export type CustomMessageRequestPayload = {
105101
testId: string;
106102
request: any;

‎packages/playwright/src/isomorphic/teleReceiver.ts‎

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ export type JsonFullResult = {
136136
};
137137

138138
export type JsonEvent = JsonOnConfigureEvent | JsonOnBlobReportMetadataEvent | JsonOnEndEvent | JsonOnExitEvent | JsonOnProjectEvent | JsonOnBeginEvent | JsonOnTestBeginEvent
139-
| JsonOnTestEndEvent | JsonOnStepBeginEvent | JsonOnStepEndEvent | JsonOnAttachEvent | JsonOnErrorEvent | JsonOnTestPausedEvent | JsonOnStdIOEvent;
139+
| JsonOnTestEndEvent | JsonOnStepBeginEvent | JsonOnStepEndEvent | JsonOnAttachEvent | JsonOnErrorEvent | JsonOnStdIOEvent;
140140

141141
export type JsonOnConfigureEvent = {
142142
method: 'onConfigure';
@@ -170,15 +170,6 @@ export type JsonOnTestBeginEvent = {
170170
};
171171
};
172172

173-
export type JsonOnTestPausedEvent = {
174-
method: 'onTestPaused';
175-
params: {
176-
testId: string;
177-
resultId: string;
178-
errors: reporterTypes.TestError[];
179-
};
180-
};
181-
182173
export type JsonOnTestEndEvent = {
183174
method: 'onTestEnd';
184175
params: {
@@ -296,10 +287,6 @@ export class TeleReporterReceiver {
296287
this._onTestBegin(params.testId, params.result);
297288
return;
298289
}
299-
if (method === 'onTestPaused') {
300-
this._onTestPaused(params.testId, params.resultId, params.errors);
301-
return;
302-
}
303290
if (method === 'onTestEnd') {
304291
this._onTestEnd(params.test, params.result);
305292
return;
@@ -375,15 +362,6 @@ export class TeleReporterReceiver {
375362
this._reporter.onTestBegin?.(test, testResult);
376363
}
377364

378-
private _onTestPaused(testId: string, resultId: string, errors: reporterTypes.TestError[]) {
379-
const test = this._tests.get(testId)!;
380-
const result = test.results.find(r => r._id === resultId)!;
381-
382-
result.errors.push(...errors);
383-
result.error = result.errors[0];
384-
void this._reporter.onTestPaused?.(test, result);
385-
}
386-
387365
private _onTestEnd(testEndPayload: JsonTestEnd, payload: JsonTestResultEnd) {
388366
const test = this._tests.get(testEndPayload.testId)!;
389367
test.timeout = testEndPayload.timeout;

‎packages/playwright/src/mcp/test/testContext.ts‎

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ export class TestContext {
212212

213213
claimStdio();
214214
try {
215-
const setupReporter = new MCPListReporter({ configDir, screen, includeTestId: true });
215+
const setupReporter = new ListReporter({ configDir, screen, includeTestId: true });
216216
const { status } = await runner.runGlobalSetup([setupReporter]);
217217
if (status !== 'passed')
218218
return { output: testRunnerAndScreen.output.join('\n'), status };
@@ -239,7 +239,7 @@ export class TestContext {
239239
: new Promise<never>(() => {});
240240

241241
try {
242-
const reporter = new MCPListReporter({ configDir, screen, includeTestId: true });
242+
const reporter = new ListReporter({ configDir, screen, includeTestId: true });
243243
status = await Promise.race([
244244
runner.runTests(reporter, params).then(result => result.status),
245245
testRunnerAndScreen.waitForTestPaused().then(() => 'paused' as const),
@@ -341,10 +341,3 @@ const bestPracticesMarkdown = `
341341
- NEVER! use page.waitForTimeout()
342342
- NEVER! use page.evaluate()
343343
`;
344-
345-
class MCPListReporter extends ListReporter {
346-
override async onTestPaused() {
347-
// ListReporter waits for user input to resume, we don't want that in MCP.
348-
await new Promise<void>(() => {});
349-
}
350-
}

‎packages/playwright/src/reporters/base.ts‎

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -522,12 +522,6 @@ function quotePathIfNeeded(path: string): string {
522522
return path;
523523
}
524524

525-
const kReportedSymbol = Symbol('reported');
526-
527-
export function markErrorsAsReported(result: TestResult) {
528-
(result as any)[kReportedSymbol] = result.errors.length;
529-
}
530-
531525
export function formatResultFailure(screen: Screen, test: TestCase, result: TestResult, initialIndent: string): ErrorDetails[] {
532526
const errorDetails: ErrorDetails[] = [];
533527

@@ -542,8 +536,7 @@ export function formatResultFailure(screen: Screen, test: TestCase, result: Test
542536
});
543537
}
544538

545-
const reportedIndex = (result as any)[kReportedSymbol] || 0;
546-
for (const error of result.errors.slice(reportedIndex)) {
539+
for (const error of result.errors) {
547540
const formattedError = formatError(screen, error);
548541
errorDetails.push({
549542
message: indent(formattedError.message, initialIndent),

‎packages/playwright/src/reporters/blob.ts‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import { resolveOutputFile, CommonReporterOptions } from './base';
2929
import { TeleReporterEmitter } from './teleEmitter';
3030

3131
import type { BlobReporterOptions } from '../../types/test';
32-
import type { FullConfig, FullResult, TestCase, TestResult } from '../../types/testReporter';
32+
import type { FullConfig, FullResult, TestResult } from '../../types/testReporter';
3333
import type { BlobReportMetadata, JsonAttachment, JsonEvent } from '../isomorphic/teleReceiver';
3434
import type { EventEmitter } from 'events';
3535

@@ -68,11 +68,6 @@ export class BlobReporter extends TeleReporterEmitter {
6868
super.onConfigure(config);
6969
}
7070

71-
override async onTestPaused(test: TestCase, result: TestResult) {
72-
// onTestPaused is only relevant for interactive use, not for blob replays.
73-
// merge-reports still gets onStepBegin/onStepEnd for pausing, but not the interactive part, so this is a no-op.
74-
}
75-
7671
override async onEnd(result: FullResult): Promise<void> {
7772
await super.onEnd(result);
7873

‎packages/playwright/src/reporters/dot.ts‎

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
import { getAsBooleanFromENV } from '@utils/env';
1818

19-
import { markErrorsAsReported, TerminalReporter } from './base';
19+
import { TerminalReporter } from './base';
2020

2121
import type { DotReporterOptions } from '../../types/test';
2222
import type { FullResult, Suite, TestCase, TestError, TestResult } from '../../types/testReporter';
@@ -74,26 +74,6 @@ class DotReporter extends TerminalReporter {
7474
this._counter = 0;
7575
}
7676

77-
async onTestPaused(test: TestCase, result: TestResult) {
78-
// Without TTY, user cannot interrupt the pause. Let's skip it.
79-
if (!process.stdin.isTTY && !process.env.PW_TEST_DEBUG_REPORTERS)
80-
return;
81-
82-
this.screen.stdout.write('\n');
83-
if (test.outcome() === 'unexpected') {
84-
this.writeLine(this.screen.colors.red(this.formatTestHeader(test, { indent: ' ' })));
85-
this.writeLine(this.formatResultErrors(test, result));
86-
markErrorsAsReported(result);
87-
this.writeLine(this.screen.colors.yellow(' Paused on error. Press Ctrl+C to end.') + '\n');
88-
} else {
89-
this.writeLine(this.screen.colors.yellow(this.formatTestHeader(test, { indent: ' ' })));
90-
this.writeLine(this.screen.colors.yellow(' Paused at test end. Press Ctrl+C to end.') + '\n');
91-
}
92-
this._counter = 0;
93-
94-
await new Promise<void>(() => {});
95-
}
96-
9777
override async onEnd(result: FullResult) {
9878
await super.onEnd(result);
9979
this.screen.stdout.write('\n');

‎packages/playwright/src/reporters/failures.ts‎

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
import { msToString } from '@isomorphic/formatUtils';
1818
import { getAsBooleanFromENV } from '@utils/env';
1919

20-
import { markErrorsAsReported, TerminalReporter } from './base';
20+
import { TerminalReporter } from './base';
2121

2222
import type { FailuresReporterOptions } from '../../types/test';
2323
import type { FullResult, TestCase, TestError, TestResult } from '../../types/testReporter';
@@ -80,23 +80,6 @@ class FailuresReporter extends TerminalReporter {
8080
this.writeLine(this.formatError(error).message);
8181
}
8282

83-
async onTestPaused(test: TestCase, result: TestResult) {
84-
// Without TTY, the user cannot interrupt the pause.
85-
if (!process.stdin.isTTY && !process.env.PW_TEST_DEBUG_REPORTERS)
86-
return;
87-
88-
this._maybeWriteNewLine();
89-
if (test.outcome() === 'unexpected') {
90-
this._printFailure(test);
91-
markErrorsAsReported(result);
92-
this.writeLine(this.screen.colors.yellow(' Paused on error. Press Ctrl+C to end.'));
93-
} else {
94-
this.writeLine(this.screen.colors.yellow(this.formatTestHeader(test, { indent: ' ' })));
95-
this.writeLine(this.screen.colors.yellow(' Paused at test end. Press Ctrl+C to end.'));
96-
}
97-
await new Promise<void>(() => {});
98-
}
99-
10083
override async onEnd(result: FullResult) {
10184
await super.onEnd(result);
10285
this._maybeWriteNewLine();

‎packages/playwright/src/reporters/internalReporter.ts‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,6 @@ export class InternalReporter implements ReporterV2 {
7474
this._reporter.onStdErr?.(chunk, test, result);
7575
}
7676

77-
async onTestPaused(test: TestCase, result: TestResult) {
78-
this._addSnippetToTestErrors(test, result);
79-
return await this._reporter.onTestPaused?.(test, result);
80-
}
81-
8277
onTestEnd(test: TestCase, result: TestResult) {
8378
this._addSnippetToTestErrors(test, result);
8479
this._reporter.onTestEnd?.(test, result);

0 commit comments

Comments
 (0)