Skip to content

Commit ce81b80

Browse files
fix(chromium): apply timezone to service workers (#44021)
Co-authored-by: microsoft-playwright-automation[bot] <203992400+microsoft-playwright-automation[bot]@users.noreply.github.com>
1 parent 8fd981f commit ce81b80

4 files changed

Lines changed: 18 additions & 4 deletions

File tree

‎packages/playwright-core/src/server/chromium/crPage.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1261,7 +1261,7 @@ async function emulateLocale(session: CRSession, locale: string) {
12611261
}
12621262
}
12631263

1264-
async function emulateTimezone(session: CRSession, timezoneId: string) {
1264+
export async function emulateTimezone(session: CRSession, timezoneId: string) {
12651265
try {
12661266
await session.send('Emulation.setTimezoneOverride', { timezoneId: timezoneId });
12671267
} catch (exception) {

‎packages/playwright-core/src/server/chromium/crServiceWorker.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,15 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16+
import { debugLogger } from '@utils/debugLogger';
1617
import { Worker } from '../page';
1718
import { createHandle, CRExecutionContext } from './crExecutionContext';
1819
import { CRNetworkManager } from './crNetworkManager';
1920
import { BrowserContext } from '../browserContext';
2021
import * as network from '../network';
2122
import { ConsoleMessage } from '../console';
2223
import { stackTraceToLocation } from './crProtocolHelper';
23-
import { calculateUserAgentMetadata } from './crPage';
24+
import { calculateUserAgentMetadata, emulateTimezone } from './crPage';
2425

2526
import type { CRBrowserContext } from './crBrowser';
2627
import type { CRSession } from './crConnection';
@@ -67,6 +68,8 @@ export class CRServiceWorker extends Worker {
6768
});
6869

6970
session.send('Runtime.enable', {}).catch(e => {});
71+
if (browserContext._options.timezoneId)
72+
emulateTimezone(session, browserContext._options.timezoneId).catch(error => debugLogger.log('error', error));
7073
session.send('Runtime.runIfWaitingForDebugger').catch(e => {});
7174
session.on('Inspector.targetReloadedAfterCrash', () => {
7275
// Resume service worker after restart.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,6 @@
11
// Mock script for background extension
2+
globalThis.initialTimezone = {
3+
timezone: Intl.DateTimeFormat().resolvedOptions().timeZone,
4+
localDate: new Date('2030-01-01T23:00').toISOString(),
5+
};
26
globalThis.MAGIC = 42;

‎tests/library/chromium/extensions.spec.ts‎

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,14 +90,21 @@ it.describe('MV3', () => {
9090
await context.close();
9191
});
9292

93-
it('CR-037 should give access to the service worker', async ({ launchPersistentContext, asset }) => {
93+
it('CR-037 should give access to the service worker', {
94+
annotation: { type: 'issue', description: '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/microsoft/playwright/issues/43983' }
95+
}, async ({ launchPersistentContext, asset }) => {
9496
const extensionPath = asset('extension-mv3-simple');
95-
const context = await launchPersistentContext(extensionPath);
97+
const timezoneId = Intl.DateTimeFormat().resolvedOptions().timeZone === 'Asia/Tokyo' ? 'America/Jamaica' : 'Asia/Tokyo';
98+
const context = await launchPersistentContext(extensionPath, { timezoneId });
9699
const serviceWorkers = context.serviceWorkers();
97100
const serviceWorker = serviceWorkers.length ? serviceWorkers[0] : await context.waitForEvent('serviceworker');
98101
expect(serviceWorker).toBeTruthy();
99102
expect(context.serviceWorkers()).toContain(serviceWorker);
100103
await expect.poll(() => serviceWorker.evaluate(() => (globalThis as any).MAGIC)).toBe(42);
104+
expect(await serviceWorker.evaluate(() => (globalThis as any).initialTimezone)).toEqual({
105+
timezone: timezoneId,
106+
localDate: timezoneId === 'Asia/Tokyo' ? '2030-01-01T14:00:00.000Z' : '2030-01-02T04:00:00.000Z',
107+
});
101108
await context.close();
102109
expect(context.backgroundPages().length).toBe(0);
103110
});

0 commit comments

Comments
 (0)