From 43e23090a0c5146d87589e9dce18ab55f1a1b71e Mon Sep 17 00:00:00 2001
From: kate bonner <katebonner277@gmail.com>
Date: Wed, 26 Aug 2026 20:39:12 -0400
Subject: [PATCH] Use real ButtonV2 prop values in the Skills tab
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The Skills tab shipped with four size values and three variants that are not in
ButtonV2's unions — size accepts "small" | "normal" | "large" and variant has no
"secondary" — so the workspace has failed `bun typecheck` with 7 errors since it
landed. The pre-push hook runs that same typecheck, which means this has been
blocking pushes on every branch in the fork, not just its own.

Mapped to the values the rest of settings-v2 already uses: "xs"/"sm" → "small"
(13 existing uses), "secondary" → "neutral" (10). Rendering is unchanged in
intent — these are the nearest real names for what the markup was asking for.

Typecheck is now 30/30 across the workspace.
---
 packages/app/src/components/settings-v2/skills.tsx | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/packages/app/src/components/settings-v2/skills.tsx b/packages/app/src/components/settings-v2/skills.tsx
index cd1199abc..ce3fe56de 100644
--- a/packages/app/src/components/settings-v2/skills.tsx
+++ b/packages/app/src/components/settings-v2/skills.tsx
@@ -102,7 +102,7 @@ export const SettingsSkillsV2: Component = () => {
                     description={provider.path ?? provider.url ?? ""}
                   >
                     <ButtonV2
-                      size="xs"
+                      size="small"
                       variant="ghost"
                       onClick={() => ctrl.removeProvider(provider.id)}
                       aria-label={`Remove ${provider.id}`}
@@ -117,11 +117,11 @@ export const SettingsSkillsV2: Component = () => {
         </SettingsListV2>
 
         <div style="display:flex;gap:8px;margin-top:12px;">
-          <ButtonV2 size="sm" variant="secondary" onClick={() => ctrl.addDirectory()}>
+          <ButtonV2 size="small" variant="neutral" onClick={() => ctrl.addDirectory()}>
             <Icon name="plus" />
             {language.t("settings.skills.action.add_directory")}
           </ButtonV2>
-          <ButtonV2 size="sm" variant="secondary" onClick={() => ctrl.autodiscover()}>
+          <ButtonV2 size="small" variant="neutral" onClick={() => ctrl.autodiscover()}>
             <Icon name="magnifying-glass" />
             Autodiscover
           </ButtonV2>
@@ -139,8 +139,8 @@ export const SettingsSkillsV2: Component = () => {
                     description={item.path}
                   >
                     <ButtonV2
-                      size="xs"
-                      variant="secondary"
+                      size="small"
+                      variant="neutral"
                       onClick={() =>
                         ctrl.addProvider({
                           id: item.name,