From a0e622c771aa3fd457ea57c956c66f784e1d5bee Mon Sep 17 00:00:00 2001 From: JJ Lee Date: Fri, 7 Aug 2026 16:08:42 -0400 Subject: [PATCH] fix: remove dead sidebar-left toggle from v2 titlebar MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The IconButtonV2 calling layout.sidebar.toggle() had no consumer in NewLayout — WorkbenchPanel only mounts in the legacy SplitFrame path. The button flipped a boolean no active component observed. Leave a comment for re-addition when WorkbenchPanel is ported to layout-new.tsx. Closes harmoniqs/amicode#265 --- packages/app/src/components/titlebar.tsx | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/packages/app/src/components/titlebar.tsx b/packages/app/src/components/titlebar.tsx index 671cf082b5..368a784d5f 100644 --- a/packages/app/src/components/titlebar.tsx +++ b/packages/app/src/components/titlebar.tsx @@ -404,21 +404,11 @@ export function Titlebar(props: { update?: TitlebarUpdate; debugTools?: { visibl aria-pressed={layout.route().type === "home"} /> - {/* amicode(workbench S1): the sessions-panel toggle, v2 titlebar - edition — the legacy grid-branch button never rendered here, - so the panel had no affordance (S1.4 probe). sidebar-LEFT: - this one drives the left sessions panel. */} - } - state={layout.sidebar.opened() ? "pressed" : undefined} - onClick={() => layout.sidebar.toggle()} - aria-label={language.t("command.sidebar.toggle")} - aria-expanded={layout.sidebar.opened()} - /> + {/* Removed: sidebar-left toggle button (harmoniqs/amicode#265). + The button called layout.sidebar.toggle() but no component in + NewLayout observes that signal — WorkbenchPanel only mounts in + the legacy SplitFrame path. Re-add here when WorkbenchPanel is + ported to layout-new.tsx. */}