This repository was archived by the owner on Mar 26, 2026. It is now read-only.
feat: port REST transport to Ads templates - #1003
Merged
Merged
Conversation
software-dov
requested review from
a team,
arithmetic1728,
busunkim96 and
tseaver
September 30, 2021 23:12
google-cla
Bot
added
the
cla: yes
software-dov
force-pushed
the
ads-rest
branch
from
September 30, 2021 23:48
e34fe57 to
4e687e7
Compare
arithmetic1728
approved these changes
Oct 1, 2021
tseaver
approved these changes
Oct 1, 2021
software-dov
force-pushed
the
ads-rest
branch
from
October 15, 2021 16:48
4e687e7 to
6c2276b
Compare
software-dov
force-pushed
the
ads-rest
branch
from
November 23, 2021 00:45
d39b970 to
5e5df3e
Compare
vam-google
approved these changes
Nov 29, 2021
vam-google
left a comment
vam-google
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Can you please put in the PR description details about how this was/can be tested? Ideally we want to test it by generating full Ads simply client and running some integration tests with it.
vam-google
reviewed
Nov 29, 2021
vam-google
left a comment
vam-google
left a comment
Contributor
There was a problem hiding this comment.
@software-dov The unit tests seem to be failing. Can you please fix them? (some are complaining about indentation being wrong)
software-dov
force-pushed
the
ads-rest
branch
from
December 10, 2021 01:00
5e5df3e to
48b454e
Compare
software-dov
force-pushed
the
ads-rest
branch
2 times, most recently
from
December 16, 2021 00:52
fef1f0d to
8bb33a0
Compare
Add REST transport to Ads templates Add REST transport tests to Ads generated unit tests Boost google-api-core dependency version Rewrite of REST transport call stubs to assist testing Add fragment tests for Ads Multiple bugfixes
software-dov
force-pushed
the
ads-rest
branch
from
December 29, 2021 18:12
cae00ad to
54e311c
Compare
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add REST transport tests to Ads generated unit tests
Boost google-api-core dependency version
Minor bugfixes