From 8ca0601f902b3af0282e04475cf8da9de9e2134c Mon Sep 17 00:00:00 2001 From: Colin Misare Date: Wed, 2 Jul 2014 21:55:39 -0600 Subject: [PATCH 1/2] including ListOptions in RepositoryListForksOptions for pagination --- github/repos_forks.go | 2 ++ github/repos_forks_test.go | 10 ++++++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/github/repos_forks.go b/github/repos_forks.go index aeb24b20e77..1fec8292c13 100644 --- a/github/repos_forks.go +++ b/github/repos_forks.go @@ -13,6 +13,8 @@ type RepositoryListForksOptions struct { // How to sort the forks list. Possible values are: newest, oldest, // watchers. Default is "newest". Sort string `url:"sort,omitempty"` + + ListOptions } // ListForks lists the forks of the specified repository. diff --git a/github/repos_forks_test.go b/github/repos_forks_test.go index b48cd5a7835..73feb141bbe 100644 --- a/github/repos_forks_test.go +++ b/github/repos_forks_test.go @@ -18,11 +18,17 @@ func TestRepositoriesService_ListForks(t *testing.T) { mux.HandleFunc("/repos/o/r/forks", func(w http.ResponseWriter, r *http.Request) { testMethod(t, r, "GET") - testFormValues(t, r, values{"sort": "newest"}) + testFormValues(t, r, values{ + "sort": "newest", + "page": "3", + }) fmt.Fprint(w, `[{"id":1},{"id":2}]`) }) - opt := &RepositoryListForksOptions{Sort: "newest"} + opt := &RepositoryListForksOptions{ + Sort: "newest", + ListOptions: ListOptions{Page: 3}, + } repos, _, err := client.Repositories.ListForks("o", "r", opt) if err != nil { t.Errorf("Repositories.ListForks returned error: %v", err) From 18bea1d754e5946adedaa5ac513459f9c9f59186 Mon Sep 17 00:00:00 2001 From: Colin Misare Date: Wed, 2 Jul 2014 22:30:16 -0600 Subject: [PATCH 2/2] forgot to fmt --- github/repos_forks_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/github/repos_forks_test.go b/github/repos_forks_test.go index 73feb141bbe..965a0663931 100644 --- a/github/repos_forks_test.go +++ b/github/repos_forks_test.go @@ -26,7 +26,7 @@ func TestRepositoriesService_ListForks(t *testing.T) { }) opt := &RepositoryListForksOptions{ - Sort: "newest", + Sort: "newest", ListOptions: ListOptions{Page: 3}, } repos, _, err := client.Repositories.ListForks("o", "r", opt)