From 074d9c78e52308a8b7182e01f02c43536746e4bd Mon Sep 17 00:00:00 2001 From: Zhangyi Yuan Date: Mon, 7 Sep 2026 10:29:14 +0800 Subject: [PATCH] Fix stale codegen references in copilot-instructions.md nodejs/scripts/generate-session-types.ts and the generate:session-types npm script were both removed by #464, which replaced them with scripts/codegen and 'npm run generate'. The Java generator path was also missing its java/ prefix. --- .github/copilot-instructions.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index 476f4e5689..ea3f8082fa 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -13,7 +13,7 @@ - Language entry points: `nodejs/src/client.ts`, `python/README.md`, `go/README.md`, `dotnet/README.md` - Java: `java/README.md`, `java/pom.xml`, `java/sdk/pom.xml`, `java/copilot-native/pom.xml` - Test harness & E2E: `test/harness/*`, Python harness wrapper `python/e2e/testharness/proxy.py` -- Schemas & type generation: `nodejs/scripts/generate-session-types.ts` +- Schemas & type generation: `scripts/codegen/` - Session snapshots used by E2E: `test/snapshots/` (used by the replay proxy) - Docs style guide: `.github/instructions/docs-style.instructions.md` (used for `docs/**`) @@ -23,7 +23,7 @@ - Install deps: `just install` (runs npm ci, uv pip install -e, go mod download, dotnet restore) - Format all: `just format` | Lint all: `just lint` | Test all: `just test` - Per-language: - - Node: `cd nodejs && npm ci` → `npm test` (Vitest), `npm run generate:session-types` to regenerate session-event types + - Node: `cd nodejs && npm ci` → `npm test` (Vitest), `npm run generate` to regenerate session-event types - Python: `cd python && uv pip install -e . --group dev` → `uv run pytest` (E2E tests use the test harness) - Go: `cd go && go test ./...` - .NET: `cd dotnet && dotnet test test/GitHub.Copilot.SDK.Test.csproj` @@ -68,6 +68,6 @@ ## Boundaries — files you must NOT hand-edit ⛔ -- `java/sdk/src/generated/java/` — auto-generated by `scripts/codegen/java.ts`; regenerate with `cd java && mvn generate-sources -Pcodegen`. -- `nodejs/src/generated/` — auto-generated by `npm run generate:session-types`. +- `java/sdk/src/generated/java/` — auto-generated by `java/scripts/codegen/java.ts`; regenerate with `cd java && mvn generate-sources -Pcodegen`. +- `nodejs/src/generated/` — auto-generated by `cd nodejs && npm run generate`. - `test/snapshots/` — authoritative test fixtures; add/edit YAML here to change E2E behavior, but don't delete without understanding downstream impact.