From 82d7e1a433ffbda44d231be2a23f306fd9b569d9 Mon Sep 17 00:00:00 2001 From: Alexander Alderman Webb Date: Wed, 5 Aug 2026 17:52:18 +0200 Subject: [PATCH 1/3] test(arq): Avoid race between error and transaction --- tests/integrations/arq/test_arq.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/integrations/arq/test_arq.py b/tests/integrations/arq/test_arq.py index 2e01c7005b..bd2de21079 100644 --- a/tests/integrations/arq/test_arq.py +++ b/tests/integrations/arq/test_arq.py @@ -730,7 +730,6 @@ async def division(_): events = [item.payload for item in items] exception_event = events[0] assert exception_event["exception"]["values"][0]["type"] == "ZeroDivisionError" - assert exception_event["transaction"] == "division" else: events = capture_events() @@ -742,8 +741,7 @@ async def division(_): await worker.close() - exception_event = events[1] - assert exception_event["exception"]["values"][0]["type"] == "ZeroDivisionError" + (exception_event,) = (event for event in events if "exception" in "event") assert exception_event["transaction"] == "division" assert exception_event["extra"]["arq-job"]["task"] == "division" From bdfe828445ddf5f4987b750c8a8528bdd3591eae Mon Sep 17 00:00:00 2001 From: Alexander Alderman Webb Date: Wed, 5 Aug 2026 17:53:07 +0200 Subject: [PATCH 2/3] . --- tests/integrations/arq/test_arq.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/integrations/arq/test_arq.py b/tests/integrations/arq/test_arq.py index bd2de21079..b6429fc18a 100644 --- a/tests/integrations/arq/test_arq.py +++ b/tests/integrations/arq/test_arq.py @@ -730,6 +730,7 @@ async def division(_): events = [item.payload for item in items] exception_event = events[0] assert exception_event["exception"]["values"][0]["type"] == "ZeroDivisionError" + assert exception_event["transaction"] == "division" else: events = capture_events() @@ -742,6 +743,7 @@ async def division(_): await worker.close() (exception_event,) = (event for event in events if "exception" in "event") + assert exception_event["exception"]["values"][0]["type"] == "ZeroDivisionError" assert exception_event["transaction"] == "division" assert exception_event["extra"]["arq-job"]["task"] == "division" From e262a6cf6bfe59988b41b29b559398bebf0d9d53 Mon Sep 17 00:00:00 2001 From: Alexander Alderman Webb Date: Wed, 5 Aug 2026 17:56:37 +0200 Subject: [PATCH 3/3] fix typo --- tests/integrations/arq/test_arq.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/integrations/arq/test_arq.py b/tests/integrations/arq/test_arq.py index b6429fc18a..5601c6dea3 100644 --- a/tests/integrations/arq/test_arq.py +++ b/tests/integrations/arq/test_arq.py @@ -742,7 +742,7 @@ async def division(_): await worker.close() - (exception_event,) = (event for event in events if "exception" in "event") + (exception_event,) = (event for event in events if "exception" in event) assert exception_event["exception"]["values"][0]["type"] == "ZeroDivisionError" assert exception_event["transaction"] == "division"