From b7fd3fc09b8bc963d4433e37dedb13f3d116a9c2 Mon Sep 17 00:00:00 2001 From: Daniel Griesser Date: Fri, 13 Mar 2020 11:49:34 +0100 Subject: [PATCH 1/2] fix: Set op in transation --- packages/node/src/handlers.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/node/src/handlers.ts b/packages/node/src/handlers.ts index 4e84bb548e0c..9b97b6b2503a 100644 --- a/packages/node/src/handlers.ts +++ b/packages/node/src/handlers.ts @@ -34,11 +34,14 @@ export function tracingHandler(): ( const hub = getCurrentHub(); const transaction = hub.startSpan({ - transaction: `${reqMethod}|${reqUrl}`, + op: 'http.server', + transaction: `${reqMethod} ${reqUrl}`, }); + hub.configureScope(scope => { scope.setSpan(transaction); }); + res.once('finish', () => { transaction.setHttpStatus(res.statusCode); transaction.finish(); From f30bda9a93028a4bcf49ec9b27d26bf5685f8054 Mon Sep 17 00:00:00 2001 From: Daniel Griesser Date: Fri, 13 Mar 2020 11:53:15 +0100 Subject: [PATCH 2/2] meta: Changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2dd69981bc3f..c14297a0797e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ - [apm] fix: Use Performance API for timings when available, including Web Workers (#2492) - [apm] fix: Remove Performance references (#2495) +- [apm] fix: Set `op` in node http.server transaction (#2496) ## 5.14.1